Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix subscription activation using email when auth v2 is enabled #5472

Conversation

lmac012
Copy link
Contributor

@lmac012 lmac012 commented Jan 14, 2025

Task/Issue URL: https://app.asana.com/0/488551667048375/1209143210335480/f

Description

This PR fixes an issue where subscription details aren't fetched from BE after activating subscription using email. The issue only occurs when auth v2 is enabled.

Steps to test this PR

  • Ensure authApiV2 FF is enabled
  • Go to app settings -> "I Have a Subscription" -> "Add via Email"
  • Proceed with activating subscription using email until you see success confirmation ("Your Privacy Pro subscription has been added to this device!")
  • Tap "Done"
  • Verify that you land on subscription settings screen, and it shows correct expiration/renewal date.
  • Go Back / tap arrow in the toolbar
  • Verify that app settings show correct Privacy Pro state

No UI changes

Copy link
Contributor Author

lmac012 commented Jan 14, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@lmac012 lmac012 marked this pull request as ready for review January 14, 2025 23:50
@lmac012 lmac012 merged commit e8ef461 into develop Jan 15, 2025
8 checks passed
@lmac012 lmac012 deleted the fix/lukasz/auth-v2-missing-subscription-data-after-activation-using-email branch January 15, 2025 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants