Send pixel category param as lowercase #5628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CrisBarreiro
approved these changes
Feb 10, 2025
laghee
deleted the
feature/kate/malicious-site-protection/lowercase-pixel-params
branch
tr4200812
pushed a commit
to tr4200812/Dutifully-Adelaide-
that referenced
this pull request
Mar 7, 2025
Task/Issue URL: https://app.asana.com/0/0/1209359933476105/f ### Description We should be firing all pixel params in lowercase, so need to convert the malicious feed category param before sending. ### Steps to test this PR _Feature 1_ - [x] Filter logcat on "pixel" - [x] Navigate to [privacy test pages phishing page](https://www.privacy-test-pages.site/security/badware/phishing.html) - [x] Check that `m_malicious-site-protection_error-page-shown` pixel is sent with `category` param in all lowercase - [x] Click "Advanced" and "Accept Risk and Visit Site" - [x] Check that `m_malicious-site-protection_visit-site` pixel is sent with `category` param all lowercase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1209359933476105/f
Description
We should be firing all pixel params in lowercase, so need to convert the malicious feed category param before sending.
Steps to test this PR
Feature 1
m_malicious-site-protection_error-page-shownpixel is sent withcategoryparam in all lowercasem_malicious-site-protection_visit-sitepixel is sent withcategoryparam all lowercase