Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dedup credentials suggestions and sort them by latest usage #5675

Conversation

cmonfortep
Copy link
Contributor

@cmonfortep cmonfortep commented Feb 21, 2025

Task/Issue URL: https://app.asana.com/0/488551667048375/1209453476472067

Description

We introduce the same logic to dedup credentials and sorting for Autofill Service.
That includes updating last used timestamp when we autofill outside our app, to improve UX.

Steps to test this PR

Feature 1

  • install this branch
  • Select DDG as autofill provider
  • Create a bunch of logins (same username and passwords) for mlb.mlb.com, securea.mlb.com and www.mlb.com
  • Create another login for www.mlb.com with a different username
  • Visit www.mlb.com in our browser
  • You will see 2 logins suggested
  • Now go to another browser and visit the same site
  • Ensure you only get 2 logins, same order from the autofill provider
  • Select the second one
  • Now go back to our browser
  • Trigger again the suggestions prompt
  • Ensure the order has changed now (since you selected the second one in the previous step)

UI changes

Before After
!(Upload before screenshot) (Upload after screenshot)

@cmonfortep
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@cmonfortep cmonfortep requested a review from CDRussell February 21, 2025 10:43
@CDRussell CDRussell self-assigned this Feb 21, 2025
@cmonfortep cmonfortep force-pushed the feature/cristian/autofill/dedup_suggestions_autofill_service branch from 51bc542 to d1cac5d Compare February 24, 2025 18:31
@cmonfortep cmonfortep merged commit 449975a into develop Feb 24, 2025
7 checks passed
@cmonfortep cmonfortep deleted the feature/cristian/autofill/dedup_suggestions_autofill_service branch February 24, 2025 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants