Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support skipping onboarding with build flag or for internal builds #5681

Merged

Conversation

CDRussell
Copy link
Member

@CDRussell CDRussell commented Feb 24, 2025

Task/Issue URL: https://app.asana.com/0/608920331025315/1209378492776844

Description

Adds a quick way to shortcut to the end of onboarding, offering a one-tap way to become fully onboarded from the pre-onboarding flow. It does this by surfacing a button to Skip Onboarding.

The skip button will only show up for builds which:

  • are internal build type,
  • OR were built with the gradle flag -Pskip-onboarding

The button will show up after the remote config has been successfully downloaded.

Steps to test this PR

ℹ️ Add logcat filter: message~:"App configuration sync was successful”

Play build type, no skip flag

  • Fresh install, with play type (no skip build flag). e.g., ./gradlew installPD
  • Launch the app and wait for privacy config to download
  • Verify the skip button does not appear

Play build type, with skip flag

  • Fresh install, with play type and include skip build flag. e.g., /.gradlew installPD -Pskip-onboarding
  • Launch the app and wait for the privacy config to download
  • Verify the skip button does show
  • Tap the skip button; verify you are taken to the new tab screen with no more onboarding
  • Kill and relaunch the app; verify you don’t see onboarding

Internal build type, no skip flag

  • Fresh install, with internal type (no skip build flag). e.g., /.gradlew installID
  • Launch the app and wait for the privacy config to download
  • Verify the skip button does show
  • For completeness, this time do not skip onboarding. Complete onboarding as normal and verify everything works as usual.

Internal build type, with skip flag

  • Fresh install, with internal type and include skip build flag. e.g., /.gradlew installID -Pskip-onboarding
  • Launch the app and wait for the privacy config to download
  • Verify the skip button does show

UI changes

Screenshot 2025-02-21 at 16 30 21

Copy link
Member Author

CDRussell commented Feb 24, 2025

@CDRussell CDRussell force-pushed the feature/craig/support_skipping_onboarding_from_build_flag branch 2 times, most recently from fa1a69f to 98d4381 Compare February 24, 2025 12:52
@CDRussell CDRussell force-pushed the feature/craig/support_skipping_onboarding_from_build_flag branch from 98d4381 to cc0e92f Compare February 24, 2025 13:07
@CDRussell CDRussell marked this pull request as ready for review February 24, 2025 13:08
Copy link
Contributor

@nalcalag nalcalag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works as expected 💯

@CDRussell CDRussell merged commit d979ade into develop Feb 25, 2025
7 checks passed
@CDRussell CDRussell deleted the feature/craig/support_skipping_onboarding_from_build_flag branch February 25, 2025 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants