SplashScreen Animation: Add fail to launch mitigation #5690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
mikescamell
force-pushed
the
feature/mike/splashscreen-animation/add-fail-to-launch-mitigation
branch
3 times, most recently
from
1b46cc2 to
b215c81
Compare
- Added a job to send a pixel and determine the view to show after a delay if the splash screen animation fails to exit. - Added the ability to cancel the aforementioned job. - Launched the job in `LaunchBridgeActivity`. - Cancelled the job when the splash screen exit animation listener is triggered.
mikescamell
force-pushed
the
feature/mike/splashscreen-animation/add-fail-to-launch-mitigation
branch
from
b215c81 to
745df7c
Compare
mikescamell
force-pushed
the
revert-5666-feature/mike/splashscreen-animation/revert-splashscreen-animation
branch
from
2d9d451 to
4005b4f
Compare
CDRussell
approved these changes
Mar 3, 2025
| @@ -16,7 +16,6 @@ | |||
|
|
|||
| <resources> | |||
| <style name="Theme.DuckDuckGo.Splash" parent="Theme.SplashScreen"> | |||
| <item name="android:windowSplashScreenAnimationDuration">1435</item> | |||
There was a problem hiding this comment.
Why is this being removed? (not a problem; just curious)
There was a problem hiding this comment.
On Android 12L only you specifically have to set the animation duration. On Android 13 and above it's automatically derived from the AnimatedVectorDrawable.
mikescamell
merged commit 1d569d7
into
revert-5666-feature/mike/splashscreen-animation/revert-splashscreen-animation
6 of 7 checks passed
mikescamell
deleted the
feature/mike/splashscreen-animation/add-fail-to-launch-mitigation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1207908166761516/1209495201524764
Description
Added a fallback mechanism to handle cases where the splash screen exit animation fails to trigger. The fallback automatically proceeds to the next screen after a 1.5-second delay if the normal exit animation doesn't occur.
We now also only target Android 13 and above with the Splashscreen animation after seeing mention of issues on Android 12L.
Steps to test this PR
Android 12L testing fallback
m_splashscreen_failed_to_launchpixel firedAndroid 12L testing normal launch
Test other OS versions
Test that the splashscreen still works on other Android OS versions. A suggested range could be 26, 30, 33, 35
On 33+
On <= 32
UI changes
No visual changes to the splash screen appearance or animation.
Demo
Emulator Android 12L Simulating fallback
Screen_recording_20250225_155714.mp4
Emulator Android 12L back to static logo
Screen_recording_20250225_155802.mp4
Device Pixel 6a Android 12L (32)
Screen_recording_20250226_103258.mp4
Device Fujitsu F-01L Android 8.1 (27)
Screen_recording_20250226_104210.mp4
Device Samsung Galaxy Note 9 Android 10 (29)
Screen_recording_20250226_105113.mp4
Device Motorola G20 Android 11 (30)
Screen_recording_20250226_105911.mp4
Device Samsung Galaxy A51 Android 12 (31)
Screen_recording_20250226_110610.mp4
Device Oppo CPH2557 Android 14 (34)
Screen.Recording.2025-02-26.at.12.02.34.mov