Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboarding: Tap to complete typing animation #5693

Merged
merged 3 commits into from
Feb 27, 2025

Conversation

nalcalag
Copy link
Contributor

@nalcalag nalcalag commented Feb 26, 2025

Task/Issue URL: https://app.asana.com/0/1176956903599313/1209263950737398

Description

Implemented changes:

  1. All Dax dialogs → Finish type animation when tapping anywhere inside the full dialog surface (If there is an invisible view, it won't dismiss on that part)
  2. Pre-onbaording Dax dialogs → Finish type animation when tapping anywhere on the pre-onboarding screens

Steps to test this PR

Pre onboarding

  • Fresh install
  • Tap anywhere on the welcome screen to finish typing animation within Dax dialogs
  • Tap anywhere on the dialog's surface to dismiss the typing animation (⚠️ If there is an invisible view, the typing animation won't be dismissed)

Onboarding

  • Search suggestions Dax dialog will appear
  • Tap anywhere on the dialog's surface to dismiss the dialog (⚠️ If there is an invisible view, the typing animation won't be dismissed)
  • Tap on a search suggestion
  • Tap anywhere on the dialog's background image to dismiss the typing animation
  • Go to bbc.com and Trackers dialog will appear
  • Tap anywhere on the dialog's surface to dismiss the dialog
  • Tap on the dialog's primary button
  • In-context fire dialog will appear
  • Leave the animation finish by itself
  • Tap on Skip
  • Open a new tab and End dialog should appear
  • Tap anywhere on the dialog's surface to dismiss the typing animation

No UI changes

@nalcalag
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@nalcalag nalcalag marked this pull request as ready for review February 26, 2025 08:17
@nalcalag nalcalag merged commit 5f612a6 into develop Feb 27, 2025
8 checks passed
@nalcalag nalcalag deleted the feature/noelia/tap_to_complete_typing_animation branch February 27, 2025 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants