Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement pixels for feature discoverability #5703

Merged
merged 7 commits into from
Mar 3, 2025

Conversation

LukasPaczos
Copy link
Contributor

@LukasPaczos LukasPaczos commented Feb 27, 2025

Task/Issue URL: https://app.asana.com/0/0/1209376654707617

Description

Implements the required pixels (see the task).

I suggest reviewing commit by commit. If that's still problematic, let me know, I'm happy to separate the changes into independent PRs.

Steps to test this PR

  • Passwords & Autofill
    • Open the setting screen.
    • Verify that m_autofill_management_opened pixel is sent with has_credentials_saved=0 parameter.
    • Save a password and reopen the setting screen.
    • Verify that m_autofill_management_opened pixel is sent with has_credentials_saved=1 parameter.
  • Sync
    • Open the setting screen.
    • Verify that ms_sync_pressed pixel is sent with is_enabled=0 parameter.
    • Enable sync and reopen the setting screen.
    • Verify that ms_sync_pressed pixel is sent with is_enabled=1 parameter.
  • Duck Chat
    • Open Duck Chat settings screen.
    • Verify that settings_aichat_pressed pixel is sent with was_used_before=0 parameter.
    • Open Duck Chat from browser overflow menu.
    • Verify that aichat_open_browser_menu pixel is sent with was_used_before=0 parameter.
    • Open Duck Chat from new tab overflow menu.
    • Verify that aichat_open_new_tab_menu pixel is sent with was_used_before=1 parameter.
    • Open Duck Chat settings screen.
    • Verify that settings_aichat_pressed pixel is sent with was_used_before=1 parameter.
  • Duck Player
    • Open Duck Player setting screen.
    • Verify that duckplayer_setting_pressed pixel is sent with was_used_before=0 parameter.
    • Open a video with Duck Player.
    • Open Duck Player setting screen.
    • Verify that duckplayer_setting_pressed pixel is sent with was_used_before=1 parameter.
  • Email protection
    • Open email protection setting screen.
    • Verify that ms_email_protection_setting_pressed pixel is sent with is_signed_in=0 parameter.
    • Sign in with an email and reopen the setting screen.
    • Verify that ms_email_protection_setting_pressed pixel is sent with is_signed_in=1 parameter.
  • Privacy Pro
    • Click on "Get Privacy Pro".
    • Verify that m_privacy-pro_app-settings_get_click pixel is sent.
  • VPN
    • Activate a test subscription (or make PPro screens available via other means) and open VPN settings screen.
    • Verify that m_netp_ev_setting_pressed_c pixel is sent with was_used_before=0 parameter.
    • Enable VPN and reopen the VPN settings page.
    • Verify that m_netp_ev_setting_pressed_c pixel is sent with was_used_before=1 parameter.
    • Disable VPN and reopen the VPN settings page.
    • Verify that m_netp_ev_setting_pressed_c pixel is sent with was_used_before=1 parameter.

@LukasPaczos LukasPaczos force-pushed the feature/lukasz-p/pixels-to-measure-discovery-2 branch from c4be544 to 88dd14a Compare February 28, 2025 13:43
@LukasPaczos LukasPaczos requested a review from anikiki March 3, 2025 10:06
@anikiki anikiki self-assigned this Mar 3, 2025
Copy link
Contributor

@anikiki anikiki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works as expected! 🎉

@LukasPaczos LukasPaczos merged commit 9b4958e into develop Mar 3, 2025
6 checks passed
@LukasPaczos LukasPaczos deleted the feature/lukasz-p/pixels-to-measure-discovery-2 branch March 3, 2025 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants