Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add fallback logic to extract package id from window node #5706

Merged

Conversation

cmonfortep
Copy link
Contributor

@cmonfortep cmonfortep commented Feb 27, 2025

Task/Issue URL: https://app.asana.com/0/1200156640058969/1209279712661813

Description

Adds fallback logic when package Id couldn't be found when traversing the view hierarchy.

Steps to test this PR

smoke test feature works as usual

Feature 1

  • install Max android app
  • go to the login form
  • you should now get a suggestion "open passwords) indicating we've detected the login form

UI changes

Before After
!(Upload before screenshot) (Upload after screenshot)

@cmonfortep
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@cmonfortep cmonfortep requested a review from CDRussell February 27, 2025 15:21
@CDRussell CDRussell self-assigned this Feb 28, 2025
Copy link
Member

@CDRussell CDRussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as discussed elsewhere, can’t easily get hold of that app in my region to test against, but changes LGTM

@cmonfortep cmonfortep merged commit 8324c27 into develop Mar 3, 2025
8 checks passed
@cmonfortep cmonfortep deleted the feature/cristian/autofill/planb_when_package_not_found branch March 3, 2025 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants