This repository was archived by the owner on Feb 24, 2025. It is now read-only.
Support for Duck Player custom error settings in privacy config #1232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1209151829557390
iOS PR: duckduckgo/iOS#3970
macOS PR: duckduckgo/macos-browser#3872
What kind of version bump will this require?: Major/Minor/Patch
Description:
Adds Privacy Config support for the Duck Player custom error view
Steps to test this PR:
Follow the steps here: https://app.asana.com/0/1142021229838617/1209392401656236
OS Testing:
Internal references:
Software Engineering Expectations
Technical Design Template