Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Sync E2E tests failing on missing Settings #29

Merged
merged 4 commits into from
Feb 18, 2025

Conversation

dus7
Copy link
Contributor

@dus7 dus7 commented Feb 17, 2025

Task/Issue URL: https://app.asana.com/0/414709148257752/1209404321699252
Tech Design URL:
CC: @loremattei @Bunn

Description:

Fixes Sync E2E tests failing on missing Settings button (Duck.ai button is there instead). I'm using browsing menu to open settings instead.

Steps to test this PR:

  1. Make sure Sync E2E tests pass (https://github.com/duckduckgo/apple-browsers/actions/runs/13376155400)

Definition of Done (Internal Only):


Internal references:

Software Engineering Expectations
Technical Design Template

@dus7 dus7 changed the title Mariusz/fix sync e2e tests Fix Sync E2E tests failing on missing Settings Feb 17, 2025
@dus7 dus7 force-pushed the mariusz/fix-sync-e2e-tests branch 2 times, most recently from 2b0ac46 to 0b30737 Compare February 17, 2025 17:18
@dus7 dus7 force-pushed the mariusz/fix-sync-e2e-tests branch from 0b30737 to 4c8f8fc Compare February 17, 2025 17:58
@dus7 dus7 marked this pull request as ready for review February 17, 2025 19:34
@dus7 dus7 requested a review from graeme February 17, 2025 19:35
Copy link
Contributor

@Bunn Bunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Thanks @dus7
Apologies for missing those, I did the changes here and thought I had all covered since for some reason all of them were passing locally. Probably had some caching issue or something.

@dus7 dus7 removed the request for review from graeme February 17, 2025 20:23
@dus7 dus7 merged commit 8d36d3c into main Feb 18, 2025
5 checks passed
@dus7 dus7 deleted the mariusz/fix-sync-e2e-tests branch February 18, 2025 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants