The "char" type might be signed, both hash functions are defined to w… #15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ork on unsigned 8-bit values.
Description:
For example, DJB's C code for this hash function is:
uint32 cdb_hash(buf,len)
unsigned char *buf;
unsigned int len;
{
uint32 h;
h = 5381;
while (len) {
--len;
h += (h << 5);
h ^= (uint32) *buf++;
}
return h;
}
This code uses + in place of ^, but that I think is a choice and not just an oversight.
Steps to test this PR:
1.
1.
Internal references:
Software Engineering Expectations
Technical Design Template