Skip to content
This repository was archived by the owner on Feb 24, 2025. It is now read-only.

Commit

Permalink
Universal auth v1 and v2 NetworkProtection (#3914)
Browse files Browse the repository at this point in the history
Task/Issue URL:
https://app.asana.com/0/72649045549333/1209279739041319/f

**Description**:

This PR introduces a few changes and some unused code in network
protection allowing the future adoption of Auth V2.
All code related to Auth V2 is not used; instead, Auth V1 is maintained.
  • Loading branch information
federicocappelli authored Feb 4, 2025
1 parent 48d9366 commit 1154ab5
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion DuckDuckGo-iOS.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -11987,7 +11987,7 @@
repositoryURL = "https://github.com/DuckDuckGo/BrowserServicesKit.git";
requirement = {
kind = exactVersion;
version = 234.0.0;
version = 235.0.0;
};
};
9F8FE9472BAE50E50071E372 /* XCRemoteSwiftPackageReference "lottie-spm" */ = {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@
"kind" : "remoteSourceControl",
"location" : "https://github.com/DuckDuckGo/BrowserServicesKit.git",
"state" : {
"revision" : "4376de073a92ca6c69fcf31c28cfcfaf6b9727d0",
"version" : "234.0.0"
"revision" : "8ea6cdb74fed2e9ff9d60aafe636291dff8024dc",
"version" : "235.0.0"
}
},
{
Expand Down
2 changes: 1 addition & 1 deletion DuckDuckGo/NetworkProtectionConvenienceInitialisers.swift
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ extension NetworkProtectionLocationListCompositeRepository {
let settings = AppDependencyProvider.shared.vpnSettings
self.init(
environment: settings.selectedEnvironment,
tokenStore: AppDependencyProvider.shared.networkProtectionKeychainTokenStore,
tokenHandler: AppDependencyProvider.shared.networkProtectionKeychainTokenStore,
errorEvents: .networkProtectionAppDebugEvents
)
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -475,7 +475,7 @@ final class NetworkProtectionPacketTunnelProvider: PacketTunnelProvider {
snoozeTimingStore: NetworkProtectionSnoozeTimingStore(userDefaults: .networkProtectionGroupDefaults),
wireGuardInterface: DefaultWireGuardInterface(),
keychainType: .dataProtection(.unspecified),
tokenStore: tokenStore,
tokenHandler: tokenStore,
debugEvents: Self.networkProtectionDebugEvents(controllerErrorStore: errorStore),
providerEvents: Self.packetTunnelProviderEvents,
settings: settings,
Expand Down

0 comments on commit 1154ab5

Please sign in to comment.