This repository was archived by the owner on Feb 24, 2025. It is now read-only.
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Use E-TLD+1 when matching domain for login saves (#3943)
Task/Issue URL: https://app.asana.com/0/72649045549333/1209272524872735 **Description**: Right now, we will offer to autofill into a page which is considered an E-TLD+1 match. But we aren’t as good at comparing E-TLD+1 when it comes to considering whether to offer to save it or not. We should detect we have a domain saved already and don’t offer to save when entering credentials for an equivalent subdomain This should also apply to other scenarios like offering to update the saved password; we should also consider E-TLD+1 matches **Steps to test this PR**: https://app.asana.com/0/1203822806345703/1209279526650235 **Definition of Done (Internal Only)**: * [ ] Does this PR satisfy our [Definition of Done](https://app.asana.com/0/1202500774821704/1207634633537039/f)? **Copy Testing**: * [ ] Use of correct apostrophes in new copy, ie `’` rather than `'` **Orientation Testing**: * [ ] Portrait * [ ] Landscape **Device Testing**: * [ ] iPhone SE (1st Gen) * [ ] iPhone 8 * [ ] iPhone X * [ ] iPhone 14 Pro * [ ] iPad **OS Testing**: * [ ] iOS 15 * [ ] iOS 16 * [ ] iOS 17 **Theme Testing**: * [ ] Light theme * [ ] Dark theme --- ###### Internal references: [Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) [Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943)
- Loading branch information