Skip to content
This repository was archived by the owner on Feb 24, 2025. It is now read-only.

Commit

Permalink
Use E-TLD+1 when matching domain for login saves (#3943)
Browse files Browse the repository at this point in the history
Task/Issue URL: https://app.asana.com/0/72649045549333/1209272524872735

**Description**:

Right now, we will offer to autofill into a page which is considered an
E-TLD+1 match.
But we aren’t as good at comparing E-TLD+1 when it comes to considering
whether to offer to save it or not.
We should detect we have a domain saved already and don’t offer to save
when entering credentials for an equivalent subdomain
This should also apply to other scenarios like offering to update the
saved password; we should also consider E-TLD+1 matches

**Steps to test this PR**:
https://app.asana.com/0/1203822806345703/1209279526650235

**Definition of Done (Internal Only)**:

* [ ] Does this PR satisfy our [Definition of
Done](https://app.asana.com/0/1202500774821704/1207634633537039/f)?

**Copy Testing**:

* [ ] Use of correct apostrophes in new copy, ie `’` rather than `'`

**Orientation Testing**:

* [ ] Portrait
* [ ] Landscape

**Device Testing**:

* [ ] iPhone SE (1st Gen)
* [ ] iPhone 8
* [ ] iPhone X
* [ ] iPhone 14 Pro
* [ ] iPad

**OS Testing**:

* [ ] iOS 15
* [ ] iOS 16
* [ ] iOS 17

**Theme Testing**:

* [ ] Light theme
* [ ] Dark theme

---
###### Internal references:
[Software Engineering
Expectations](https://app.asana.com/0/59792373528535/199064865822552)
[Technical Design
Template](https://app.asana.com/0/59792373528535/184709971311943)
  • Loading branch information
graeme authored Feb 12, 2025
1 parent 4676645 commit 3aa6322
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 8 deletions.
3 changes: 1 addition & 2 deletions DuckDuckGo-iOS.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -8653,7 +8653,6 @@
F194FAED1F14E2B3009B4DF8 /* UIFontExtension.swift in Sources */,
98F0FC2021FF18E700CE77AB /* AutoClearSettingsViewController.swift in Sources */,
D67969112BC84CE700BA8B34 /* SubscriptionContainerViewModel.swift in Sources */,
85DB12ED2A1FED0C000A4A72 /* AppDelegate+AppDeepLinks.swift in Sources */,
9F5179D82D54598800E40B40 /* DaxDialogsOnboardingMigrator.swift in Sources */,
98DA6ECA2181E41F00E65433 /* ThemeManager.swift in Sources */,
F1D43AFC2B99C56000BAB743 /* RootDebugViewController+VanillaBrowser.swift in Sources */,
Expand Down Expand Up @@ -12365,7 +12364,7 @@
repositoryURL = "https://github.com/DuckDuckGo/BrowserServicesKit.git";
requirement = {
kind = exactVersion;
version = 236.1.0;
version = 237.0.0;
};
};
9F8FE9472BAE50E50071E372 /* XCRemoteSwiftPackageReference "lottie-spm" */ = {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@
"kind" : "remoteSourceControl",
"location" : "https://github.com/DuckDuckGo/BrowserServicesKit.git",
"state" : {
"revision" : "7356a39ecc21ec36cb1006a6cdacdae48fe1eaae",
"version" : "236.1.0"
"revision" : "d9305bab6f4328404819b7bb3303bdfcd0bc1dbb",
"version" : "237.0.0"
}
},
{
Expand Down
3 changes: 1 addition & 2 deletions DuckDuckGo/EmailSignupViewController.swift
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,7 @@ class EmailSignupViewController: UIViewController {
}()

lazy private var vaultManager: SecureVaultManager = {
let manager = SecureVaultManager(includePartialAccountMatches: true,
shouldAllowPartialFormSaves: featureFlagger.isFeatureOn(.autofillPartialFormSaves),
let manager = SecureVaultManager(shouldAllowPartialFormSaves: featureFlagger.isFeatureOn(.autofillPartialFormSaves),
tld: AppDependencyProvider.shared.storageCache.tld)
manager.delegate = self
return manager
Expand Down
3 changes: 1 addition & 2 deletions DuckDuckGo/TabViewController.swift
Original file line number Diff line number Diff line change
Expand Up @@ -273,8 +273,7 @@ class TabViewController: UIViewController {
}

lazy var vaultManager: SecureVaultManager = {
let manager = SecureVaultManager(includePartialAccountMatches: true,
shouldAllowPartialFormSaves: featureFlagger.isFeatureOn(.autofillPartialFormSaves),
let manager = SecureVaultManager(shouldAllowPartialFormSaves: featureFlagger.isFeatureOn(.autofillPartialFormSaves),
tld: AppDependencyProvider.shared.storageCache.tld)
manager.delegate = self
return manager
Expand Down

0 comments on commit 3aa6322

Please sign in to comment.