Skip to content
This repository was archived by the owner on Feb 24, 2025. It is now read-only.

Commit

Permalink
fixes button movement from home/web to tabswitcher (#3955)
Browse files Browse the repository at this point in the history
Task/Issue URL: https://app.asana.com/0/0/1209358244103060/f
Tech Design URL:
CC:

**Description**:
Fix fire button movement by adding some padding to the fire button
image.

**Steps to test this PR**:
1. Open the tab switcher and make sure the fire button doesn't appear to
move.
2. Check on a couple of different phone types. Can ignore SE as that has
had a up/down movement problem for some time.

**Definition of Done (Internal Only)**:

* [x] Does this PR satisfy our [Definition of
Done](https://app.asana.com/0/1202500774821704/1207634633537039/f)?
  • Loading branch information
brindy authored Feb 11, 2025
1 parent c47657b commit 8ea60df
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 1 deletion.
15 changes: 15 additions & 0 deletions DuckDuckGo/Assets.xcassets/FireLeftPadded.imageset/Contents.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
{
"images" : [
{
"filename" : "fire_2.pdf",
"idiom" : "universal"
}
],
"info" : {
"author" : "xcode",
"version" : 1
},
"properties" : {
"template-rendering-intent" : "template"
}
}
Binary file not shown.
2 changes: 1 addition & 1 deletion DuckDuckGo/TabSwitcherViewController+MultiSelect.swift
Original file line number Diff line number Diff line change
Expand Up @@ -489,7 +489,7 @@ extension TabSwitcherViewController {
self.addNewTab()
})

barsHandler.fireButton.primaryAction = action(image: "Fire") { [weak self] in
barsHandler.fireButton.primaryAction = action(image: "FireLeftPadded") { [weak self] in
guard let self else { return }
self.burn(sender: self.barsHandler.fireButton)
}
Expand Down

0 comments on commit 8ea60df

Please sign in to comment.