This repository was archived by the owner on Feb 24, 2025. It is now read-only.
Privacy Dashboard 8.1.0: Improved breakage form #3802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
afterxleep
approved these changes
Jan 15, 2025
mgurgel
force-pushed
the
mgurgel/improved-breakage-form
branch
from
67e6ea0 to
44da2a4
Compare
14 tasks
mgurgel
force-pushed
the
mgurgel/improved-breakage-form
branch
from
44da2a4 to
b9cc288
Compare
mgurgel
force-pushed
the
mgurgel/improved-breakage-form
branch
from
b9cc288 to
b7776e3
Compare
mgurgel
added a commit
that referenced
this pull request
Jan 17, 2025
<!-- Note: This checklist is a reminder of our shared engineering expectations. Feel free to change it, although assigning a GitHub reviewer and the items in bold are required.⚠️ If you're an external contributor, please file an issue first before working on a PR, as we can't guarantee that we will accept your changes if they haven't been discussed ahead of time. Thanks! --> Task/Issue URL: https://app.asana.com/0/1206594217596623/1209173355503842/f **Description**: Removes automatic firing of `BrokenSiteReportShown` pixel to align with macOS. The firing of that pixel is now actively requested by the Privacy Dashboard (see duckduckgo/BrowserServicesKit#1167) This PR contains a fix for on #3802 which is why it is stacked on it. Please let me know if this is not the best way to have this code reviewed. **Steps to test this PR**: 1. Invoke the breakage form in the two possible ways: Open the Privacy Dashboard and click on "Report a problem with this site" Open the app menu ••• and click on "Report Broken Site” (iOS) 2. Confirm that the pixel `m_report-broken-site_shown` was fired 3. Submit a report 4. Confirm that the pixels `epbf` and `m_report-broken-site_sent` were fired **Definition of Done (Internal Only)**: * [ ] Does this PR satisfy our [Definition of Done](https://app.asana.com/0/1202500774821704/1207634633537039/f)? **Copy Testing**: * [ ] Use of correct apostrophes in new copy, ie `’` rather than `’` **Orientation Testing**: * [ ] Portrait * [ ] Landscape **Device Testing**: * [ ] iPhone SE (1st Gen) * [ ] iPhone 8 * [ ] iPhone X * [ ] iPhone 14 Pro * [ ] iPad **OS Testing**: * [ ] iOS 15 * [ ] iOS 16 * [ ] iOS 17 **Theme Testing**: * [ ] Light theme * [ ] Dark theme — ###### Internal references: [Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) [Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943) --------- Co-authored-by: Jacek Łyp <[email protected]>
mgurgel
changed the title
mgurgel
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Jan 20, 2025
**Required**: Task/Issue URL: https://app.asana.com/0/0/1209127604215386/f iOS PR: duckduckgo/iOS#3802 macOS PR: duckduckgo/macos-browser#3729 What kind of version bump will this require?: Minor **Description**: Upgrades Privacy Dashboard to 8.0.0, which contains the new site breakage flow as can be previewed [here](https://duckduckgo.github.io/privacy-dashboard/app-debug/html/iframe.html?platforms=android%2Cios%2Cmacos%2Cwindows%2Cbrowser&screen=breakageForm) Figma: https://www.figma.com/design/eeVdakW2pjijbDlv8HUSgZ/O-E---Report-Broken-Site-Flow-(Design-Updates-2024-09)?node-id=4024-6272&m=dev <!-- Tagging instructions If this PR isn't ready to be merged for whatever reason it should be marked with the `DO NOT MERGE` label (particularly if it's a draft) If it's pending Product Review/PFR, please add the `Pending Product Review` label. If at any point it isn't actively being worked on/ready for review/otherwise moving forward (besides the above PR/PFR exception) strongly consider closing it (or not opening it in the first place). If you decide not to close it, make sure it's labelled to make it clear the PRs state and comment with more information. --> **Steps to test this PR**: 1. Trigger the breakage form in the two possible ways: - Open the Privacy Dashboard and click on "Report a problem with this site" - Open the app menu ••• and click on "Report Broken Site” (iOS) or “Send Feedback > Report Broken Site” (macOS) 2. Confirm that the breakage form matches the Figma or the [web preview ](https://duckduckgo.github.io/privacy-dashboard/app-debug/html/iframe.html?platforms=android%2Cios%2Cmacos%2Cwindows%2Cbrowser&screen=breakageForm) 3. Attempt to complete a broken site report from both entry points above. Things to keep an eye on: - The “See what’s sent” toggle expands and collapses normally - When the category is “Something else”, trying to submit the form without a description should raise an alert - The description is optional for all other categories <!-- Before submitting a PR, please ensure you have tested the combinations you expect the reviewer to test, then delete configurations you *know* do not need explicit testing. Using a simulator where a physical device is unavailable is acceptable. --> **OS Testing**: * [ ] iOS 14 * [ ] iOS 15 * [ ] iOS 16 * [ ] macOS 10.15 * [ ] macOS 11 * [ ] macOS 12 --- ###### Internal references: [Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) [Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943) --------- Co-authored-by: Jacek Łyp <[email protected]>
<!-- Note: This checklist is a reminder of our shared engineering expectations. Feel free to change it, although assigning a GitHub reviewer and the items in bold are required.⚠️ If you're an external contributor, please file an issue first before working on a PR, as we can't guarantee that we will accept your changes if they haven't been discussed ahead of time. Thanks! --> Task/Issue URL: https://app.asana.com/0/1206594217596623/1209173355503842/f **Description**: Removes automatic firing of `BrokenSiteReportShown` pixel to align with macOS. The firing of that pixel is now actively requested by the Privacy Dashboard (see duckduckgo/BrowserServicesKit#1167) This PR contains a fix for on #3802 which is why it is stacked on it. Please let me know if this is not the best way to have this code reviewed. **Steps to test this PR**: 1. Invoke the breakage form in the two possible ways: Open the Privacy Dashboard and click on "Report a problem with this site" Open the app menu ••• and click on "Report Broken Site” (iOS) 2. Confirm that the pixel `m_report-broken-site_shown` was fired 3. Submit a report 4. Confirm that the pixels `epbf` and `m_report-broken-site_sent` were fired **Definition of Done (Internal Only)**: * [ ] Does this PR satisfy our [Definition of Done](https://app.asana.com/0/1202500774821704/1207634633537039/f)? **Copy Testing**: * [ ] Use of correct apostrophes in new copy, ie `’` rather than `’` **Orientation Testing**: * [ ] Portrait * [ ] Landscape **Device Testing**: * [ ] iPhone SE (1st Gen) * [ ] iPhone 8 * [ ] iPhone X * [ ] iPhone 14 Pro * [ ] iPad **OS Testing**: * [ ] iOS 15 * [ ] iOS 16 * [ ] iOS 17 **Theme Testing**: * [ ] Light theme * [ ] Dark theme — [Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) [Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943) --------- Co-authored-by: Jacek Łyp <[email protected]>
mgurgel
force-pushed
the
mgurgel/improved-breakage-form
branch
from
a211046 to
7cf6d8f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1209127604215384/f
CC: @jaceklyp
Description:
Upgrades Privacy Dashboard to 8.0.0, which contains the new site breakage flow as can be previewed here
Figma: https://www.figma.com/design/eeVdakW2pjijbDlv8HUSgZ/O-E---Report-Broken-Site-Flow-(Design-Updates-2024-09)?node-id=4024-6272&m=dev
Steps to test this PR:
Confirm that the breakage form matches the Figma or the web preview
Attempt to complete a broken site report from both entry points above. Things to keep an eye on:
Definition of Done (Internal Only):
Copy Testing:
’rather than'Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
Internal references:
Software Engineering Expectations
Technical Design Template