Skip to content
This repository was archived by the owner on Feb 24, 2025. It is now read-only.

Fix iOS hotfix workflow inputs #3959

Merged
merged 2 commits into from
Feb 13, 2025
Merged

Fix iOS hotfix workflow inputs #3959

merged 2 commits into from
Feb 13, 2025

Conversation

kshann
Copy link
Contributor

@kshann kshann commented Feb 12, 2025

Task/Issue URL: https://app.asana.com/0/0/1209377152368982
Tech Design URL:
CC:

Description:
Fixes inputs for iOS hotfix flows. This was tested in monorepo.

  1. Appstore input for build
    image
  2. Fix inputs for base-branch
    image
    image

Steps to test this PR:

  1. We can't really test this unless we run a hotfix but see above as I ran one in monorepo here

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@kshann kshann marked this pull request as ready for review February 12, 2025 03:59
@kshann kshann requested a review from ayoy February 12, 2025 03:59
Copy link
Contributor

@ayoy ayoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @kshann!

@ayoy ayoy assigned kshann and unassigned ayoy Feb 12, 2025
@kshann kshann merged commit 8c89a2d into main Feb 13, 2025
29 checks passed
@kshann kshann deleted the kieran/fix-ios-hotfix-inputs branch February 13, 2025 00:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants