Skip to content
This repository has been archived by the owner on Feb 24, 2025. It is now read-only.

risky domains protection #3963

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

SabrinaTardio
Copy link
Contributor

@SabrinaTardio SabrinaTardio commented Feb 13, 2025

Task/Issue URL: https://app.asana.com/0/1204186595873227/1209409234171914

Description: Adds risky domain protection to our VPN

Steps to test this PR:
DNS Settings Migration

  1. Run the app from main branch and set a custom DNS
  2. Run the app from this branch
  3. Check that the DNS is still set the the custom one

Feature Flag

  1. Check that no option is visible for risky domains protection under the default DNS
  2. Select the default DNS and visit http://malware.privacy-test-pages.site/ check it loads
  3. Go to debug menu Feature Flags -> turn the Network protection block risky domain flag on
  4. Check that when you visit http://malware.privacy-test-pages.site/ it still loads (the flag should not make the VPN restart)
  5. Go to the VPN settings and check that the risky site protection option is visible and it is on
  6. Restart the VPN and check that http://malware.privacy-test-pages.site/ is blocked

Toggle DNS settings

  1. Try toggle the option on and off and check by visiting the test page that the blocking/non blocking is respected
  2. Toggle between default and custom DNS and check that the previously selected risk protection option is retained
  3. When going back to custom check that the IP address previously selected is retained

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@SabrinaTardio SabrinaTardio changed the title first draft implementation risky domains protection Feb 14, 2025
@SabrinaTardio SabrinaTardio marked this pull request as ready for review February 14, 2025 14:07
Copy link

github-actions bot commented Feb 14, 2025

Warnings
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.
Messages
📖

You seem to be updating localized strings. Make sure that you request translations and include translated strings before you ship your change. See Localization Guidelines for more information.

Generated by 🚫 dangerJS against 42cad50

@SabrinaTardio SabrinaTardio removed the request for review from diegoreymendez February 14, 2025 15:26
Copy link

This PR has been inactive for more than 7 days and will be automatically closed 7 days from now.

@github-actions github-actions bot added the stale label Feb 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant