Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update version of duplexify to 4.1.3 #499

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Klaitos
Copy link
Contributor

@Klaitos Klaitos commented Jan 9, 2025

In this PR:

  • Bug fix (non-breaking change which fixes an issue)

Issues reference:

Sub package bug is in : https://github.com/mafintosh/duplexify/pull/40/files
I reproduced the same fix as they did in google storage package https://github.com/googleapis/nodejs-storage/pull/2422/files
#485

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you lint your code with pnpm lint locally prior to submission?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran build with pnpm build of your changes locally?
  • Have you successfully ran tests with pnpm test of your changes locally?
  • Have you commit using Conventional Commits?

@Klaitos Klaitos force-pushed the fix/force-duplexify-version branch from b13480a to cb69b32 Compare January 9, 2025 12:42
@Klaitos Klaitos changed the title fix(deps): overrides version of duplexify to 4.1.3 fix(deps): update version of duplexify to 4.1.3 Jan 9, 2025
@Klaitos
Copy link
Contributor Author

Klaitos commented Jan 15, 2025

@fox1t anychance to review this and release ? this would fix a few crash issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant