Add Vitest testing to the CI pipeline #13
Merged
+410
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
ilamanov
force-pushed
the
01-21-add_vitest_testing_to_the_ci_pipeline
branch
3 times, most recently
from
5650a12 to
2368520
Compare
ilamanov
commented
Jan 22, 2025
| DUNE_API_KEY=test |
There was a problem hiding this comment.
We need to have some value here because otherwise the hooks return early when the api key is not set. We are mocking all requests so the actual API key is not needed
ilamanov
force-pushed
the
01-21-add_vitest_testing_to_the_ci_pipeline
branch
2 times, most recently
from
77509a9 to
fc891e1
Compare
GarrettJMU
reviewed
Jan 23, 2025
src/svm/useSvmTokenBalances.ts
Outdated
| @@ -4,6 +4,7 @@ import { TokenBalancesParams, BalanceData, FetchError } from "./types"; | |||
| import { fetchSvmBalances } from "./duneApi"; | |||
| import { useDeepMemo } from "../useDeepMemo"; | |||
| import { useGetApiKey } from "../provider"; | |||
| import { isAddress } from "viem"; | |||
src/svm/useSvmTransactions.ts
Outdated
| @@ -30,7 +31,7 @@ export const useSvmTransactions = ( | |||
|
|
|||
| // Function to fetch data for a specific page | |||
| const fetchDataAsync = async (offset: string | null) => { | |||
| if (!walletAddress) return; | |||
| if (!apiKey || !walletAddress || !isAddress(walletAddress)) return; | |||
There was a problem hiding this comment.
will this work for svm?
There was a problem hiding this comment.
Good catch, this kinda got lost during the big copy paste:( I removed it
ilamanov
force-pushed
the
01-21-add_vitest_testing_to_the_ci_pipeline
branch
from
fc891e1 to
f19602c
Compare
GarrettJMU
approved these changes
Jan 23, 2025
Updated in #16 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also updates the test files which were failing due to recent rename to EVM files.
Adds SVM tests as well