Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move GMX Project To Hourly Directory #7500

Merged

Conversation

AIDataMaster
Copy link
Contributor

…ed Event Model

Thank you for contributing to Spellbook 🪄

Please open the PR in draft and mark as ready when you want to request a review.

Description:

This PR moves the dbt models to the hourly_spellbook directory for improved refresh frequency. Additionally, the _withdrawal_created dbt model was modified to include three new columns:

  • withdrawal_type
  • long_token_swap_path
  • short_token_swap_path

quick links for more information:

@github-actions github-actions bot marked this pull request as draft January 20, 2025 10:07
@github-actions github-actions bot added WIP work in progress dbt: hourly covers the hourly dbt subproject labels Jan 20, 2025
@AIDataMaster AIDataMaster marked this pull request as ready for review January 20, 2025 10:55
@github-actions github-actions bot added ready-for-review this PR development is complete, please review and removed WIP work in progress labels Jan 20, 2025
@AIDataMaster AIDataMaster changed the title Move dbt models to hourly_spellbook directory. Modify WithdrawalCreat… Move GMX Project To Hourly Directory Jan 20, 2025
@jeff-dude jeff-dude self-assigned this Jan 20, 2025
@jeff-dude
Copy link
Member

not a blocker for this PR, since models run efficiently, but a general rule of thumb i like to consider:
for PRs which move models across projects, we should keep as-is, then any changes can happen after merge and live in prod on new project. this would allow me the flexibility to turn off the modified / table rebuild in prod, as the tables aren't actually changing and don't require a rebuild. any future changes are likely on subset of models, so that PR merge would rebuild less in prod.

again, all good for this one, just a thought for future 🙏

@jeff-dude jeff-dude added ready-for-merging and removed ready-for-review this PR development is complete, please review labels Jan 20, 2025
@AIDataMaster
Copy link
Contributor Author

not a blocker for this PR, since models run efficiently, but a general rule of thumb i like to consider: for PRs which move models across projects, we should keep as-is, then any changes can happen after merge and live in prod on new project. this would allow me the flexibility to turn off the modified / table rebuild in prod, as the tables aren't actually changing and don't require a rebuild. any future changes are likely on subset of models, so that PR merge would rebuild less in prod.

again, all good for this one, just a thought for future 🙏

Okay, I will remove any changes in models to keep it simple. THank you!

@jeff-dude jeff-dude merged commit 89f2de3 into duneanalytics:main Jan 20, 2025
4 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dbt: hourly covers the hourly dbt subproject ready-for-merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants