Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding shadow to dex.trades on sonic #7584
base: main
Are you sure you want to change the base?
Adding shadow to dex.trades on sonic #7584
Changes from 6 commits
92e337c
6a5d0a4
6dc7203
4292729
9a49284
c877210
a2292a6
56f5c78
5f4cd37
1d5698b
efd308f
a1add3a
7500035
92bf873
35ca937
e80ba0f
4167b83
854e2aa
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may need to split this part into 2 spells.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so like shadow_sonic_base_trades_v1.sql and shadow_sonic_base_trades_v3.sql ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll take a look at snipping out the v2 bits since a majority of the volume goes through v3 pools.
and then double back and do another one of these for the v2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please verify this seed:
https://sonicscan.org/tx/0x7b9c8c8eb8d384b892be64f8ce461b20575a327a15a3c64e8b010a3bd0f343a8
(seems not in the table):
https://dune.com/queries/4652741
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will check it out on Monday!
thx @Hosuke
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like I managed to get the seed sorted, I think.
![image](https://private-user-images.githubusercontent.com/1681165/410475007-6d603455-b89c-46ef-8dec-9a8e3956c9c0.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkxNzMzMzQsIm5iZiI6MTczOTE3MzAzNCwicGF0aCI6Ii8xNjgxMTY1LzQxMDQ3NTAwNy02ZDYwMzQ1NS1iODljLTQ2ZWYtOGRlYy05YThlMzk1NmM5YzAucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxMCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTBUMDczNzE0WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ODFhYTFmMWU1OTVjYmRiNzk3MWVmZWE2MDU4NDQ5OWZkYmIxYmRjMTM2OGQxMDVlOWMxNDU2YzUwZTI2ZTRiOCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.F3AaCjURA0Ignaww3E9QO1HM1F8rvSpIxf0Ppd33F54)
Now I'm stuck on: Failure in test check_dex_info_relationship_dex_sonic_base_trades_
which when I run the associated query: select * from hive.test_schema.git_dunesql_74bbc6d_check_dex_info_relationship_dex_sonic_base_trades_
it returns "shadow" as missing dex info.
Failure in test check_dex_info_relationship_dex_sonic_base_trades_ (models/trades/sonic/_schema.yml)
I thought there was an entry for shadow in the _schema.yml file, but really I'm just out of my depth here.