Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add color gradients #1370

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Add color gradients #1370

wants to merge 14 commits into from

Conversation

bynect
Copy link
Member

@bynect bynect commented Aug 16, 2024

Supersedes #1286

@bynect bynect marked this pull request as ready for review August 17, 2024 17:04
@bynect
Copy link
Member Author

bynect commented Aug 17, 2024

I added the gradient only for the highlight at the moment, but it should be easy to add to the others. the cairo pattern is cached at the start. for the rest it is basically the same as #1286 but with a custom gradient type instead of a string list

@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 72.67442% with 47 lines in your changes missing coverage. Please review.

Project coverage is 65.51%. Comparing base (c1cc6d1) to head (8630daf).

Files with missing lines Patch % Lines
src/dbus.c 15.62% 27 Missing ⚠️
src/option_parser.c 73.68% 5 Missing ⚠️
src/rules.c 72.22% 5 Missing ⚠️
src/draw.c 88.57% 4 Missing ⚠️
src/notification.c 62.50% 3 Missing ⚠️
src/dunst.c 0.00% 2 Missing ⚠️
test/setting.c 91.66% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1370      +/-   ##
==========================================
+ Coverage   65.37%   65.51%   +0.14%     
==========================================
  Files          50       50              
  Lines        8321     8468     +147     
  Branches      999     1021      +22     
==========================================
+ Hits         5440     5548     +108     
- Misses       2881     2920      +39     
Flag Coverage Δ
unittests 65.51% <72.67%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bynect
Copy link
Member Author

bynect commented Aug 17, 2024

this is what it looks like
img-1723929625

@bynect
Copy link
Member Author

bynect commented Aug 17, 2024

@zappolowski @fwsmit should be ready. I already closed the old pr

@bynect
Copy link
Member Author

bynect commented Aug 17, 2024

ok fixed 🤣

@bynect bynect linked an issue Sep 26, 2024 that may be closed by this pull request
@bynect
Copy link
Member Author

bynect commented Oct 15, 2024

@zappolowski @fwsmit can I merge this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Color gradient
2 participants