Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Committee Size Comments #1526

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

fed-franz
Copy link
Contributor

No description provided.

@fed-franz fed-franz self-assigned this May 2, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 20.34% and project coverage change: -0.13 ⚠️

Comparison is base (57c6bbd) 40.18% compared to head (76a5d67) 40.05%.

❗ Current head 76a5d67 differs from pull request most recent head 64dee06. Consider uploading reports for the commit 64dee06 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1526      +/-   ##
==========================================
- Coverage   40.18%   40.05%   -0.13%     
==========================================
  Files         147      147              
  Lines        9651     9791     +140     
==========================================
+ Hits         3878     3922      +44     
- Misses       5144     5237      +93     
- Partials      629      632       +3     
Impacted Files Coverage Δ
pkg/config/genesis/config.go 0.00% <ø> (ø)
pkg/core/consensus/agreement/checkcert.go 6.97% <0.00%> (ø)
...nsensus/blockgenerator/candidate/blockgenerator.go 0.00% <0.00%> (ø)
...core/consensus/blockgenerator/candidate/genesis.go 0.00% <0.00%> (ø)
...kg/core/consensus/blockgenerator/candidate/mock.go 0.00% <0.00%> (ø)
pkg/core/consensus/committee/handler.go 70.21% <ø> (ø)
pkg/core/data/block/block.go 8.97% <0.00%> (-1.48%) ⬇️
pkg/core/data/block/certificate.go 0.00% <ø> (ø)
pkg/core/data/block/header.go 0.00% <0.00%> (ø)
pkg/core/data/ipc/transactions/fixtures.go 13.76% <0.00%> (-0.21%) ⬇️
... and 17 more

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants