-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update nextjs monorepo to v15 #541
Conversation
Reviewer's Guide by SourceryThis PR updates the Next.js monorepo to version 15, which includes several TypeScript interface updates, component restructuring, and configuration changes. The main changes involve updating the params handling in page components to use Promise-based params and improving the type safety of various components. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @duyet - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟡 Complexity: 1 issue found
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
</span>, | ||
'Enhanced ClickHouse for 300% better data compression and 2x-100x faster queries, compared with Trino + Iceberg', | ||
'Automated operations with Airflow: data replication, data processing, healthchecks, etc.', | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (complexity): Consider simplifying the responsibilities array by removing unnecessary object wrappers.
The responsibilities
array can be simplified by removing the {id, item}
wrapper while maintaining all functionality. This reduces nesting and improves readability without losing any features:
responsibilities={[
'Deprecated old stack (Spark, Iceberg, Trino) replaced by ClickHouse.',
<span key="migrate-iceberg-to-clickhouse">
Migrated 350TB+ Iceberg Data Lake to{' '}
<HoverLinks
text="ClickHouse on Kubernetes"
links={[/* ... */]}
/>
.
</span>,
'Enhanced ClickHouse for 300% better data compression and 2x-100x faster queries, compared with Trino + Iceberg',
'Automated operations with Airflow: data replication, data processing, healthchecks, etc.'
]}
The ID fields aren't being used for any purpose (sorting, filtering, etc.) and React's key props already handle unique identification where needed. This change reduces code verbosity while preserving all functionality.
Summary by Sourcery
Update the Next.js monorepo to version 15 and refactor various components across the CV and blog apps for improved data handling and performance. Enhance the insights app by adding suppressHydrationWarning to HTML elements. Remove unnecessary configuration options from the blog app.
Enhancements:
Chores: