feat(blog): update home #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's Guide by SourceryThis PR updates the blog's home page to display posts grouped by year instead of a paginated feed, improves tag normalization, and consolidates date formatting utilities. The changes also include various tag cleanup and categorization improvements across blog posts. Updated class diagram for post fetching and displayclassDiagram
class Page {
+Page()
+postsByYear: Map
+postCount: int
+pastYears: int
}
class getPostsByAllYear {
+getPostsByAllYear(fields: string[]): Map
}
class YearPost {
+YearPost(year: int)
}
Page --> getPostsByAllYear
Page --> YearPost
class normalizeTag {
+normalizeTag(tag: string): string
}
class dateFormat {
+dateFormat(date: Date, formatString: string): string
}
class distanceToNow {
+distanceToNow(dateTime: number | Date): string
}
class distanceFormat {
+distanceFormat(from: Date, to: Date): string
}
class TagList {
+TagList(tags: TagCount)
}
TagList --> normalizeTag
class Feed {
+Feed(posts: Post[])
}
Page --> Feed
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @duyet - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Comment on lines
+7
to
+15
| const normalizedTag = tag | ||
| .split(' ') | ||
| .filter((word) => word.length > 0) | ||
| .map((word) => { | ||
| return word[0].toUpperCase() + word.toLowerCase().substring(1) | ||
| }) | ||
| .join(' ') | ||
|
|
||
| return normalizedTag |
There was a problem hiding this comment.
suggestion (code-quality): Inline variable that is immediately returned (inline-immediately-returned-variable)
Suggested change
| const normalizedTag = tag | |
| .split(' ') | |
| .filter((word) => word.length > 0) | |
| .map((word) => { | |
| return word[0].toUpperCase() + word.toLowerCase().substring(1) | |
| }) | |
| .join(' ') | |
| return normalizedTag | |
| return tag | |
| .split(' ') | |
| .filter((word) => word.length > 0) | |
| .map((word) => { | |
| return word[0].toUpperCase() + word.toLowerCase().substring(1) | |
| }) | |
| .join(' '); | |
Explanation
Something that we often see in people's code is assigning to a result variableand then immediately returning it.
Returning the result directly shortens the code and removes an unnecessary
variable, reducing the mental load of reading the function.
Where intermediate variables can be useful is if they then get used as a
parameter or a condition, and the name can act like a comment on what the
variable represents. In the case where you're returning it from a function, the
function name is there to tell you what the result is, so the variable name
is unnecessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Update the blog's home page to display posts grouped by year, enhancing navigation and readability. Introduce a new page component for displaying posts by year. Improve tag normalization for consistent formatting. Update blog post metadata for clarity.
New Features:
Enhancements:
Documentation: