feat(ui): add /featured, warn for old posts #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's Guide by SourceryThis PR introduces several UI improvements including a new featured posts section, old post warnings, and various content cleanup changes. The implementation focuses on enhancing the blog's navigation and content organization while improving the user experience through better content presentation and warnings for outdated content. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @duyet - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Review instructions: all looks good
- 🟢 Testing: all looks good
- 🟡 Complexity: 1 issue found
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| * @returns {TagCount} An object where each key is a unique tag and its value | ||
| * is the number of times that tag appears across all posts. The type TagCount | ||
| * is defined as Record<string, number>. | ||
| */ | ||
| export function getAllTags(): TagCount { |
There was a problem hiding this comment.
suggestion (performance): The tags reduction could be optimized to use a single pass
Consider using a single reduce operation to build the tag count object instead of chaining multiple array operations. This would improve performance for large numbers of posts.
export function getAllTags(): TagCount {
return getAllPosts().reduce((acc: TagCount, post) => {
post.tags?.forEach(tag => acc[tag] = (acc[tag] || 0) + 1);
return acc;
}, {});
}| const extraFields = [...fields, 'date', 'featured'] | ||
| let allPosts = getAllPosts(extraFields) | ||
|
|
||
| if (featured !== undefined) { |
There was a problem hiding this comment.
issue (complexity): Consider extracting the post filtering logic into a dedicated function to improve code organization
Consider extracting the filtering logic into a separate function to improve composability and maintainability:
type PostFilter = (post: Post) => boolean;
const createFeaturedFilter = (featured?: boolean): PostFilter =>
featured === undefined ? () => true : (post) => post.featured === true;
export function getPostsByAllYear(
fields: string[] = [],
yearLimit: number = -1,
featured?: boolean
): Record<number, Post[]> {
const extraFields = [...fields, 'date', 'featured'];
const allPosts = getAllPosts(extraFields);
const filteredPosts = allPosts.filter(createFeaturedFilter(featured));
return filteredPosts.reduce((acc, post) => {
const year = new Date(post.date).getFullYear();
if (!acc[year]) acc[year] = [];
acc[year].push(post);
return acc;
}, {} as Record<number, Post[]>);
}This approach:
- Introduces a reusable PostFilter type
- Separates filtering logic into composable functions
- Makes it easier to add new filters in the future
- Maintains existing functionality while reducing complexity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Add a '/featured' page to showcase highlighted blog posts and implement a warning system for posts older than a specified number of years. Enhance the post data structure with a 'featured' attribute and update components to support and display this new feature.
New Features:
Enhancements: