Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add jitsu #562

Merged
merged 1 commit into from
Nov 30, 2024
Merged

feat: add jitsu #562

merged 1 commit into from
Nov 30, 2024

Conversation

duyet
Copy link
Owner

@duyet duyet commented Nov 30, 2024

Summary by Sourcery

New Features:

  • Integrate Jitsu analytics by adding a script to the Analytics component.

Copy link
Contributor

sourcery-ai bot commented Nov 30, 2024

Reviewer's Guide by Sourcery

This PR adds Jitsu analytics integration alongside the existing PostHog analytics by including the Jitsu tracking script in the Analytics wrapper component.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Added Jitsu analytics script integration
  • Included Jitsu tracking script using Next.js Script component
  • Set script loading strategy to 'afterInteractive' for optimal performance
  • Maintained existing PostHog analytics integration
packages/components/Analytics.tsx

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

vercel bot commented Nov 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 30, 2024 8:59am
cv ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 30, 2024 8:59am
insights ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 30, 2024 8:59am

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @duyet - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider moving the Jitsu URL to an environment variable for consistency with PostHog configuration and easier management across environments.
  • Please document the purpose of adding Jitsu alongside PostHog and ensure there's no missing initialization code required for Jitsu.
Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Review instructions: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Comment on lines +60 to +63
<Script
id="jitsu"
strategy="afterInteractive"
src="https://cm43x9afh00003b61bdnjgdkj.d.jitsu.com/p.js"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Consider moving the Jitsu URL to an environment variable

Hardcoded URLs with instance-specific identifiers should be configurable. This makes it easier to manage different environments and update the URL if needed.

      <Script
        id="jitsu"
        strategy="afterInteractive"
        src={process.env.NEXT_PUBLIC_JITSU_URL}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant