-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add jitsu #562
feat: add jitsu #562
Conversation
Reviewer's Guide by SourceryThis PR adds Jitsu analytics integration alongside the existing PostHog analytics by including the Jitsu tracking script in the Analytics wrapper component. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @duyet - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider moving the Jitsu URL to an environment variable for consistency with PostHog configuration and easier management across environments.
- Please document the purpose of adding Jitsu alongside PostHog and ensure there's no missing initialization code required for Jitsu.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Review instructions: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
<Script | ||
id="jitsu" | ||
strategy="afterInteractive" | ||
src="https://cm43x9afh00003b61bdnjgdkj.d.jitsu.com/p.js" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: Consider moving the Jitsu URL to an environment variable
Hardcoded URLs with instance-specific identifiers should be configurable. This makes it easier to manage different environments and update the URL if needed.
<Script
id="jitsu"
strategy="afterInteractive"
src={process.env.NEXT_PUBLIC_JITSU_URL}
Summary by Sourcery
New Features: