Update to pegjs version 0.10.0 #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pegjs now supports `exportVar` natively. The `peg.buildParser` function was replaced with `peg.generate`. Differences in the way the generated parser code was layed out meant having to rewrite the angular wrapper.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings grunt-peg up-to-date with version 0.10.0 of pegjs. Pegjs now supports
exportVarnatively. Thepeg.buildParserfunction was replaced withpeg.generate. Differences in the way the generatedparser code was layed out meant having to rewrite the angular wrapper.
There was one significant change. I had to choose whether to maintain backwards compatibility or to match the behavior of the pegjs
exportVaroption. By default, theformatoption is "commonjs".exportVaronly applies whenformatis "globals" or "umd". So, it is necessary to set theformatoption if you want to useexportVars.