fix(utils): compare absolute difference during binary opt

dwahdany · Jan 5, 2024 · 144e7e1 · 144e7e1
1 parent 9b90837
commit 144e7e1
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/dp_learning_ff/utils.py b/src/dp_learning_ff/utils.py
@@ -119,8 +119,8 @@ def strictness_comp(
         curr_obj = f(x)
         if (
             strictness_comp(curr_obj, target, strictly)
-            and target - curr_obj < abs_tol
-            and (target - curr_obj) / target < rel_tol
+            and abs(target - curr_obj) < abs_tol
+            and abs((target - curr_obj) / target) < rel_tol
         ):
             break
         if monotonicity_comp(x, target, f_monotonicity):