Add .clang-format and apply to dimod/include/* #742
Conversation
| NamespaceIndentation: Inner | ||
|
|
||
| # Scaled by a factor of 2 such that the base indent is 4 | ||
| AccessModifierOffset: -3 |
There was a problem hiding this comment.
dimod/include/dimod/adjvectorbqm.h
Outdated
| std::pair<const_outvars_iterator, const_outvars_iterator> | ||
| neighborhood(variable_type u) const { | ||
| std::pair<const_outvars_iterator, const_outvars_iterator> neighborhood( | ||
| variable_type u) const { |
There was a problem hiding this comment.
This feels like it should be indented 8 spaces. Not sure is that due to ContinuationIndentWidth or ConstructorInitializerIndentWidth not scaled with IndentWidth in dwave-ocean-sdk#90.
| size_type degree(variable_type v) const { | ||
| return adj[v].first.size(); | ||
| } | ||
| size_type degree(variable_type v) const { return adj[v].first.size(); } |
There was a problem hiding this comment.
Did not expect function folding like this. 😕
|
Ok, scaled the indent. @randomir , can you take another look? Figure it's better to iterate here than on dwavesystems/dwave-ocean-sdk#103 |
Codecov Report
@@ Coverage Diff @@
## master #742 +/- ##
=======================================
Coverage 92.02% 92.02%
=======================================
Files 63 63
Lines 4567 4567
=======================================
Hits 4203 4203
Misses 364 364 Continue to review full report at Codecov.
|
| dense_diagonal[v] = dense[v * (num_variables + 1)]; | ||
| dense[v * (num_variables + 1)] = 0; | ||
| if (!ignore_diagonal) { | ||
| #pragma omp parallel for |
There was a problem hiding this comment.
Annoys me that it cannot handle #pragma omp parallel for etc. There are solutions but probably not common enough to require.
See dwavesystems/dwave-ocean-sdk#90 and dwavesystems/dwave-ocean-sdk#103