Skip to content

Commit

Permalink
removing upload functions for security reasons
Browse files Browse the repository at this point in the history
  • Loading branch information
dweeves committed Oct 20, 2014
1 parent 425c2fd commit 8758932
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 8 deletions.
8 changes: 4 additions & 4 deletions magmi/web/magmi_config_setup.php
Original file line number Diff line number Diff line change
Expand Up @@ -32,15 +32,15 @@
$conf_ok = 0;
}
?>
<!-- MAGMI UPLOADER -->
<!-- MAGMI UPLOADER DISABLED FOR SECURITY REASONS -->
<?php $zipok=class_exists("ZipArchive");?>
<div class="container_12">
<div class="grid_12 subtitle">
<span>Update Magmi</span>
</div>
</div>
<div class="container_12">
<?php if($zipok){?>
<?php if(false){?>
<form method="post" enctype="multipart/form-data"
action="magmi_upload.php">
<div class="grid_12 col">
Expand Down Expand Up @@ -89,8 +89,8 @@
<?php } else {?>
<div class="grid_12 col">
<h3>Update Disabled</h3>
<div class="error">Zip library not available, Upgrade/Upload function
are not enabled</div>
<div class="error">Upgrade/Upload function
are disabled for security reasons</div>
</div>
<?php }?>
</div>
Expand Down
4 changes: 2 additions & 2 deletions magmi/web/magmi_upload.php
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?php
session_start();
/*session_start();
function extractZipDir($zip, $bdir, $zdir)
{
Expand Down Expand Up @@ -62,5 +62,5 @@ function extractZipDir($zip, $bdir, $zdir)
{
session_write_close();
die($e->getMessage());
}
}*/
header("Location: ./magmi.php");
4 changes: 2 additions & 2 deletions magmi/web/plugin_upload.php
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?php
session_start();
/*session_start();
unset($_SESSION["plugin_install_error"]);
require_once ("../inc/magmi_pluginhelper.php");
$ph = Magmi_PluginHelper::getInstance();
Expand All @@ -12,5 +12,5 @@
{
$_SESSION["plugin_install"] = array("info","Plugin packaged installed");
}
session_write_close();
session_write_close();*/
header("Location: ./magmi.php");

2 comments on commit 8758932

@neilborromeo
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was having a hard attack why it shows disabled. 👍 thanks mate

@neilborromeo
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's safe to update http://wiki.magmi.org/index.php?title=Installing_Magmi under Directory permissions / Magmi upgrade already?

Please sign in to comment.