Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return composer type #412

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Return composer type #412

wants to merge 2 commits into from

Conversation

luckyraul
Copy link

No description provided.

@mobilizer
Copy link
Contributor

I would suggest to not include "magento-module", so it is NOT copied to .modman/ and left outside of Magento root. Personally I prefer it in vendor directory, because there is no need for Magmi to be in Magento root.

Maybe some other change, that is related to these potential changes in composer.json: Add symlink to the Magmi cli interface to bin. #414

@luckyraul
Copy link
Author

In my opinion not all users want to have cli only

@mobilizer
Copy link
Contributor

@luckyraul Yes, of course. Magmi web interface is needed and great for setup and test.

Currently you need to point the webserver to the magmi web/ folder separately. E.g. on a subdomain.

(My concerns: Personally I also don't feel good with the htauth authentication used in Magmi right now. This is open for brute force attacks. (Unless I am missing any method implemented against it?)

@luckyraul
Copy link
Author

At least you have an ability to disable deploy rather then not to have any change of auto-deploy.

@coredevel
Copy link

+1 for this, it's down to developer/devops to decide whether or not to include in the project's composer file for production release, for example we have dev, integration, staging, production and production-private where composer json's differ for each env.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants