Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for value translation with select/multiselect attributes when is_configurable=0 and scope is global #556

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Allow for value translation with select/multiselect attributes when is_configurable=0 and scope is global #556

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
29fea56
Fix value translation for select/multiselect attributes.
thedotwriter Oct 17, 2017
fac3003
Allow for 0€ price to be imported.
thedotwriter Jan 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions magmi/engines/magmi_productimportengine.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1619,10 +1619,10 @@ public function createAttributes($pid, &$item, $attmap, $isnew, $itemids)
// get the item value
$ivalue = $item[$attrcode];
// get item store id for the current attribute
//if is global then , global scope applies but if configurable, back to store view scope since
//it's a select
// if the attribute is global, then global scope applies. However, for select & multiselect
// attributes, we go back to the store view scope to allow for values translation
$scope = $attrdesc["is_global"];
if ($attrcode != "price" && $attrdesc["is_configurable"] == 1)
if ($attrcode != "price" && $attrdesc["is_global"] && ($attrdesc["frontend_input"] == 'select' || $attrdesc["frontend_input"] == 'multiselect'))
{
$scope = 0;
}
Expand Down
2 changes: 1 addition & 1 deletion magmi/plugins/extra/itemprocessors/groupprice/grouppriceprocessor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ public function processItemAfterId(&$item, $params = null)
$inserts=array();
foreach ($group_cols as $key) {
$price=str_replace(",", ".", $item[$key]);
if (!empty($price)) {
if (is_numeric($price)) {
$group_id = $this->_groups[$key]['id'];

foreach ($website_ids as $website_id) {
Expand Down