-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tidy up and Clarify #23
Conversation
Bet you can't guess the context where I'm using these images ... 😜
|
@iteles please read: https://github.com/dwyl/apprenticeship/tree/tidy-up-and-clarify when you can. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nelsonic Thank you for all of these!
I have pushed a commit which just corrects some typos and left some comments here for your review pre-merge 🙌
README.md
Outdated
In fact we expect people to gravitate | ||
to the area of creativity they most enjoy | ||
and is most fulfilling/valuable to them. | ||
In the same way that reading, writing and math |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest replacing this sentence with words to the effect of: But technology and code are at the centre of what we do at dwyl (as well as the world we live in) and we have found that knowing how to code is an essential skill to working effectively here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iteles please make that as a suggestion
so that it can easily be merged in.
(I agree with any improvement anyone can make to this repo...)
I've been asking people to contribute improvements to this repo for years and yet I'm still the only one on the list ... https://github.com/dwyl/apprenticeship/graphs/contributors
Not even the people we paid to be apprentices made time to create a PR ... 😞
I still have faith that I will get better at communicating the expectations and thus future apprentices will understand what they need to do. 🌈
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nelson, I tried to make this as a suggestion but it didn't let me. It may have been due to a poor connection or just a temperamental github but I will do so now. You'll notice that I made a number of corrections in a commit, only the bare essential suggestions as comments.
I will get this done now.
README.md
Outdated
|
||
#### “_Whether you want to uncover the secrets of the universe, or you just want to pursue a career in the 21st century, basic computer programming is an essential skill to learn_.” ~ Stephen Hawking | ||
|
||
Along the way you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this sentence adds too much and would suggest removing it and ending on the quote above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iteles then just remove it. We don't need to have a discussion about each removal. All I want in this repo is that the message is communicated. If we can do that in a single paragraph, I'd be happy to delete
the rest of the text:
Show up on time every day.
Learn faster than you thought was possible.
Share your knowledge with your peers (and future self) every step.
Use your creativity to solve real human problems.
Write code
like your life depends on it.
Stay focussed; time is scarce! ⏳
But sadly, from experience we often need to err on the side of repeating ourselves. 💭
Conclusion: Please Remove Anything Superfluous. 🔪
If you are prefer to start earlier, do it! | ||
Some of us start our day at 06:00 so we get 3h | ||
of focus time *before* 09:00! | ||
Just let someone know you are available/online |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do they need to let someone know? My reasoning for getting up early (when I manage it!) is precisely because no one knows or expects me to be online so it is uninterrupted time (both remote and from people in my location). Would it be enough for them to track their time (which would eventually be visible in our app) and follow the communication protocols around issue updates?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iteles one of the highest features on my List of Desired Features for the App: dwyl/app#262 (comment) is "Focus Mode".
An apprentice "informing" people that they are woking will be as simple as them starting a timer on their task for the morning and activating "Focus Mode" so that their peers know they are working and not to be interrupted.
I haven't specified that here because we don't have that feature yet.
Once we have that feature in our App, we can update this. 👍
@iteles thank you for reviewing this PR. ☀️ |
Co-Authored-By: Nelson <[email protected]>
…into tidy-up-and-clarify
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nelsonic Thanks for all the work on this. I have committed the suggestions and merging now 👍
I've been meaning to tidy up this repo for a while ...
Why?
,What?
,Who?
,How?
sections Why? What? Who? How? #1/ama
as it's superseded bystart-here/questions.md
AMA superseded by start-here/questions.md ? #22