Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use containerized database in devcontainer and all unit tests #215

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

alexsapps
Copy link
Collaborator

No description provided.

@alexsapps alexsapps requested review from mdzirbel and jakehobbs and removed request for mdzirbel and jakehobbs January 7, 2025 08:10
@alexsapps alexsapps force-pushed the alex/devcontainer-docker-compose branch from 004c388 to 86cbd71 Compare January 7, 2025 09:46
@alexsapps alexsapps force-pushed the alex/devcontainer-docker-compose branch from 86cbd71 to 070d392 Compare January 7, 2025 19:56
Copy link

@mdzirbel mdzirbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But I'm not that familiar with the code base yet

Copy link
Member

@jakehobbs jakehobbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not familiar w/ devcontainers, but seems fine to me

@alexsapps alexsapps merged commit 995450b into master Jan 8, 2025
1 check passed
@alexsapps alexsapps deleted the alex/devcontainer-docker-compose branch January 8, 2025 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants