Fix contributing links #1399
Merged
Fix contributing links #1399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At present, when you're on the "Benefits" page, clicking on "Add new page" will take you to a form for adding a new "Pay, pension, and benefits" page, the parent of "Benefits". This might have made sense in a previous iteration of the menu/layout, but at present it's confusing. This updates things so that: - the homepage only allows you to edit itself, not add a new page (no change) - other pages with children allow you to edit the page, and clicking "Add new page" will take you to the CMS page for adding a child of that page (not a sibling, as is presently the case) - other pages without children will only allow you to edit the page We aim to keep the `src/admin/config.yml` up-to-date with pages that have children, in order to allow creation of new children via the CMS, but in cases where we haven't kept things up to date, bad CMS links should simply redirect to the main CMS page
✅ Deploy Preview for laughing-payne-b9fbd2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jdudley1123
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At present, when you're on the "Benefits" page, clicking on "Add new page" will take you to a form for adding a new "Pay, pension, and benefits" page, the parent of "Benefits". This might have made sense in a previous iteration of the menu/layout, but at present it's confusing. This updates things so that:
We aim to keep the
src/admin/config.ymlup-to-date with pages that have children, in order to allow creation of new children via the CMS, but in cases where we haven't kept things up to date, bad CMS links should simply redirect to the main CMS page