client: auto submit room settings on change #1766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 30, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1766 +/- ##
================================================
+ Coverage 62.8243% 62.8452% +0.0208%
================================================
Files 168 168
Lines 24898 24912 +14
Branches 1444 1444
================================================
+ Hits 15642 15656 +14
Misses 9203 9203
Partials 53 53 ☔ View full report in Codecov by Sentry. |
Passing run #1968 ↗︎
Details:
Review all test suite changes for PR #1766 ↗︎ |
|||||||||||||||
dyc3
force-pushed
the
04-30-wip_use_reactive_
branch
from
dc7c858 to
9669da6
Compare
dyc3
force-pushed
the
04-30-wip_also_auto_submits_settings_but_still_janky
branch
from
43a211b to
5bd10d5
Compare
dyc3
force-pushed
the
04-30-wip_use_reactive_
branch
from
9669da6 to
af16137
Compare
dyc3
force-pushed
the
04-30-wip_also_auto_submits_settings_but_still_janky
branch
from
5bd10d5 to
48dacb1
Compare
Bundle size diffdiff -u /tmp/bundle-size-base.txt/bundle-size.txt /tmp/bundle-size-head.txt/bundle-size.txt
--- /tmp/bundle-size-base.txt/bundle-size.txt 2024-04-30 23:17:00.032215657 +0000
+++ /tmp/bundle-size-head.txt/bundle-size.txt 2024-04-30 23:17:00.816220662 +0000
@@ -30,7 +30,7 @@
�[2mdist/�[22m�[2massets/�[22m�[36mAttribution-hash.js �[39m�[1m�[2m 0.34 kB�[22m�[1m�[22m�[2m │ gzip: 0.26 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[36mNotFound-hash.js �[39m�[1m�[2m 0.60 kB�[22m�[1m�[22m�[2m │ gzip: 0.32 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[36mplaceholder-hash.js �[39m�[1m�[2m 1.04 kB�[22m�[1m�[22m�[2m │ gzip: 0.48 kB�[22m
-�[2mdist/�[22m�[2massets/�[22m�[36mPasswordReset-hash.js �[39m�[1m�[2m 2.00 kB�[22m�[1m�[22m�[2m │ gzip: 0.96 kB�[22m
+�[2mdist/�[22m�[2massets/�[22m�[36mPasswordReset-hash.js �[39m�[1m�[2m 2.00 kB�[22m�[1m�[22m�[2m │ gzip: 0.95 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[36mRoomList-hash.js �[39m�[1m�[2m 2.31 kB�[22m�[1m�[22m�[2m │ gzip: 1.08 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[36mPrivacy-hash.js �[39m�[1m�[2m 2.64 kB�[22m�[1m�[22m�[2m │ gzip: 1.29 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[36mHome-hash.js �[39m�[1m�[2m 5.43 kB�[22m�[1m�[22m�[2m │ gzip: 1.34 kB�[22m
@@ -40,9 +40,9 @@
�[2mdist/�[22m�[2massets/�[22m�[36mru-hash.js �[39m�[1m�[2m 12.40 kB�[22m�[1m�[22m�[2m │ gzip: 6.42 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[36mes-hash.js �[39m�[1m�[2m 14.05 kB�[22m�[1m�[22m�[2m │ gzip: 5.97 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[36mPeertubePlayer-hash.js �[39m�[1m�[2m 16.35 kB�[22m�[1m�[22m�[2m │ gzip: 5.54 kB�[22m
-�[2mdist/�[22m�[2massets/�[22m�[36mVimeoPlayer-hash.js �[39m�[1m�[2m 39.99 kB�[22m�[1m�[22m�[2m │ gzip: 12.53 kB�[22m
-�[2mdist/�[22m�[2massets/�[22m�[36mRoom-hash.js �[39m�[1m�[2m 162.12 kB�[22m�[1m�[22m�[2m │ gzip: 50.89 kB�[22m
+�[2mdist/�[22m�[2massets/�[22m�[36mVimeoPlayer-hash.js �[39m�[1m�[2m 39.99 kB�[22m�[1m�[22m�[2m │ gzip: 12.52 kB�[22m
+�[2mdist/�[22m�[2massets/�[22m�[36mRoom-hash.js �[39m�[1m�[2m 164.05 kB�[22m�[1m�[22m�[2m │ gzip: 51.41 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[36mGoogleDrivePlayer-hash.js �[39m�[1m�[33m 604.87 kB�[39m�[22m�[2m │ gzip: 173.51 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[36mindex-hash.js �[39m�[1m�[33m 743.54 kB�[39m�[22m�[2m │ gzip: 248.18 kB�[22m
�[2mdist/�[22m�[2massets/�[22m�[36mPlyrPlayer-hash.js �[39m�[1m�[33m1,280.78 kB�[39m�[22m�[2m │ gzip: 379.37 kB�[22m
-�[32m✓ built in 24.88s�[39m
+�[32m✓ built in 25.46s�[39m |
dyc3
force-pushed
the
04-30-wip_use_reactive_
branch
from
af16137 to
bcd588a
Compare
dyc3
force-pushed
the
04-30-wip_also_auto_submits_settings_but_still_janky
branch
from
48dacb1 to
3aa9296
Compare
dyc3
force-pushed
the
04-30-wip_use_reactive_
branch
from
bcd588a to
8e74109
Compare
dyc3
force-pushed
the
04-30-wip_also_auto_submits_settings_but_still_janky
branch
from
3aa9296 to
aa23064
Compare
dyc3
force-pushed
the
04-30-wip_use_reactive_
branch
from
8e74109 to
3b4904e
Compare
dyc3
force-pushed
the
04-30-wip_also_auto_submits_settings_but_still_janky
branch
from
aa23064 to
5e6550f
Compare
dyc3
force-pushed
the
04-30-wip_use_reactive_
branch
from
3b4904e to
9539176
Compare
dyc3
force-pushed
the
04-30-wip_also_auto_submits_settings_but_still_janky
branch
from
5e6550f to
26ff667
Compare
dyc3
force-pushed
the
04-30-wip_use_reactive_
branch
from
9539176 to
520ae8d
Compare
dyc3
force-pushed
the
04-30-wip_also_auto_submits_settings_but_still_janky
branch
from
26ff667 to
fc633a2
Compare
dyc3
force-pushed
the
04-30-wip_use_reactive_
branch
from
520ae8d to
3a61b6a
Compare
dyc3
force-pushed
the
04-30-wip_also_auto_submits_settings_but_still_janky
branch
from
fc633a2 to
2c3bb53
Compare
Passing run #1969 ↗︎
Details:
Review all test suite changes for PR #1766 ↗︎ |
|||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1593