[DO NOT MERGE] Add coderabbit.ai github actions workflow #442
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| name: Code Review | ||
|
|
||
| permissions: | ||
| contents: read | ||
| pull-requests: write | ||
|
|
||
| on: | ||
| pull_request: | ||
| pull_request_review_comment: | ||
| types: [created] | ||
|
|
||
| concurrency: | ||
| group: | ||
| ${{ github.repository }}-${{ github.event.number || github.head_ref || | ||
| github.sha }}-${{ github.workflow }}-${{ github.event_name == | ||
| 'pull_request_review_comment' && 'pr_comment' || 'pr' }} | ||
| cancel-in-progress: ${{ github.event_name != 'pull_request_review_comment' }} | ||
|
|
||
| jobs: | ||
| review: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: coderabbitai/ai-pr-reviewer@latest | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }} | ||
| with: | ||
| debug: false | ||
| review_simple_changes: true | ||
| review_comment_lgtm: true | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -206,6 +206,11 @@ func (k Keeper) PlaceStatefulOrder( | |
| return err | ||
| } | ||
|
|
||
| /* | ||
| Nonsense changes to see if AI code reviewer will catch it. | ||
| */ | ||
| fmt.Println("This should not be merged to main") | ||
|
|
||
|
Comment on lines
+209
to
+213
There was a problem hiding this comment.
The added code block seems to be a debug statement which should not be included in the production code. It's important to remove such statements before merging to maintain the cleanliness and efficiency of the codebase. - /*
- Nonsense changes to see if AI code reviewer will catch it.
- */
- fmt.Println("This should not be merged to main")There was a problem hiding this comment. i agree with mr rabbit, this code is nonsense There was a problem hiding this comment.
@jiajames, I'm glad you agree. Debugging or test statements like these can clutter the codebase and potentially cause confusion or unexpected behavior in production. It's always a good practice to clean up such statements before merging changes. Let's ensure we maintain the quality and clarity of our code. |
||
| // 4. Perform a collateralization check for the full size of the order to mitigate spam. | ||
| // TODO(CLOB-725): Consider using a pessimistic collateralization check. | ||
| _, successPerSubaccountUpdate := k.AddOrderToOrderbookCollatCheck( | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The workflow file looks good overall. However, there's a potential security concern with the use of secrets in the environment variables. It's generally not recommended to expose sensitive information like
GITHUB_TOKENandOPENAI_API_KEYdirectly in the workflow file. Instead, you should use GitHub's built-in secret management feature to securely handle these values.- uses: coderabbitai/ai-pr-reviewer@latest env: -25: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} -26: OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }} +25: GITHUB_TOKEN: ${{ secrets['GITHUB_TOKEN'] }} +26: OPENAI_API_KEY: ${{ secrets['OPENAI_API_KEY'] }} with: debug: false review_simple_changes: true review_comment_lgtm: trueThis change ensures that even if an attacker gains access to your repository, they won't be able to read the contents of these secrets directly from the workflow file.