Numbers redesign #1006
Open
Numbers redesign #1006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hods, so that they can be specialized with extended number types
| @@ -241,23 +241,23 @@ define method \^ | |||
| end if | |||
| end method \^; | |||
|
|
|||
| define function logior (#rest integers) => (logior :: <integer>) | |||
| define sealed method logior (#rest integers) => (logior :: <integer>) | |||
There was a problem hiding this comment.
Converting logior (and logxor and logand) to sealed method won't change anything, since they have no required arguments, so there is no dispatch happening.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First 3 commits of the work towards a more extensible numerics are mergeable by themselves.