Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename $machine-name to $machine-architecture #1567

Merged
merged 1 commit into from
Mar 2, 2024

Conversation

cgay
Copy link
Member

@cgay cgay commented Mar 1, 2024

Keep old name for backward compatibility. The uses in djam.dylan and jam-build.dylan were the only ones that couldn't be changed right away due to bootstrap requirements.

@waywardmonkeys
Copy link
Member

#1566 is probably going to conflict with this, so I'll wait for that to land and conflicts resolved before I review.

Copy link
Member

@waywardmonkeys waywardmonkeys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't check things outside of this PR like "Did you get every instance?" ... but what's in the PR looks good so assuming you did, then all is well.

@housel
Copy link
Member

housel commented Mar 2, 2024

djam.dylan isn't a bootstrapping dependency (since it's a standalone application not used during the bootstrapping process).

@cgay
Copy link
Member Author

cgay commented Mar 2, 2024

djam.dylan isn't a bootstrapping dependency (since it's a standalone application not used during the bootstrapping process).

Possibly it was just jam-build.dylan and I made the assumption about djam.dylan. I'll amend it with djam.dylan changed and see if it bootstraps.

Keep old name for backward compatibility.
@cgay cgay merged commit 5a6d4e6 into dylan-lang:master Mar 2, 2024
3 checks passed
@cgay cgay deleted the machine-name branch March 22, 2024 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants