If-merge optimizations #1618
Merged
If-merge optimizations #1618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes fix missed cases where type-constrained values in if tests and instance? tests were substituted in the left (consequent) side of the if body computations, but not in the left side of the if merge. * sources/dfmc/optimization/assignment.dylan (maybe-rename-temporaries-in-conditional): Substitute the type-constrained value when the <if> test value appears in the left side of the <if-merge>. * sources/dfmc/optimization/calls.dylan (do-optimize-instance?-user): Substitute the type-constrained value when the <if> instance? test value appears in the left side of the <if-merge>.
|
Is it possible to make a small enough example of what the improvement does to fit in the release notes? |
* documentation/source/release-notes/2024.2.rst: Add entry to Compiler section.
housel
force-pushed
the
if-merge-optimizations
branch
from
7542e87
to
a023760
Compare
cgay
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes improve the compiler's type estimation of certain types of if expressions.