Use localtime_r instead of localtime #381
Conversation
localtime is not reentrant.
| @@ -109,7 +109,7 @@ define method native-clock-to-tm (time :: <machine-word>) => (tm :: <machine-wor | |||
| := primitive-unwrap-machine-word(time); | |||
| let tm = primitive-wrap-machine-word | |||
| (primitive-cast-pointer-as-raw | |||
| (%call-c-function ("localtime") | |||
There was a problem hiding this comment.
This should use with-storage ... you can get the size from a call into C, I guess (or another magic constant), but a define constant $tm-size = primitive-whatever(%call-c-function("dylan_sizeof_tm") ... ); shouldn't be that bad.
There was a problem hiding this comment.
(And I know that with-storage uses GC_malloc ... that's something that will change later.)
|
In addition to the comments on the code, I'm hoping that we can be better with release notes going forward ... so a release note addition, including what Dylan level stuff this impacts would be nice. |
|
Hmm, given the structure if the surrounding code, I see why it is this way and not with-structure... |
|
Test FAILed. |
localtime is not reentrant.