Skip to content

Commit

Permalink
Merge pull request #170 from cgay/dev
Browse files Browse the repository at this point in the history
Add expect-true macro for symmetry with expect-false
  • Loading branch information
cgay authored Feb 2, 2024
2 parents 675aa9d + 21c48f7 commit 64d6d82
Show file tree
Hide file tree
Showing 3 changed files with 29 additions and 0 deletions.
13 changes: 13 additions & 0 deletions assertions.dylan
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,19 @@ define macro expect
}
end macro;

// This is for symmetry with expect-false. Usually expect is preferred.
define macro expect-true
{ expect-true(?expr:expression) }
=> { expect-true(?expr, ?"expr" " is true") }

{ expect-true(?expr:expression, ?description:*) }
=> { do-check-true(method () values(?description) end,
method () values(?expr, ?"expr") end,
"expect",
terminate?: #f)
}
end macro;

// Deprecated; use expect-equal.
define macro check-equal
{ check-equal(?description:expression, ?want:expression, ?got:expression) }
Expand Down
1 change: 1 addition & 0 deletions library.dylan
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ define module testworks
expect,
expect-equal,
expect-not-equal,
expect-true,
expect-false,
expect-instance?,
expect-not-instance?,
Expand Down
15 changes: 15 additions & 0 deletions tests/testworks-test-suite.dylan
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,21 @@ define test test-expect ()
"expect of error crashes");
end test;

define test test-expect-true ()
expect-true(always(#t));
expect-true(identity(#t));
expect-true(3 = 3);
assert-equal($passed,
with-result-status () expect-true(#t) end,
"expect(#t) passes");
assert-equal($failed,
with-result-status () expect-true(#f) end,
"expect(#f) fails");
assert-equal($crashed,
with-result-status () expect-true(test-error()) end,
"expect of error crashes");
end test;

define test testworks-assert-true-test ()
assert-true(#t);
assert-true(#t, "#t is true with description");
Expand Down

0 comments on commit 64d6d82

Please sign in to comment.