This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
sequences: fix terminal bold color #644
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes set the bold color on terminals to the foreground color.
This fixes a pywal bug on iTerm in macOS: when using a light color theme, foreground-coloured bold characters are displayed with the background color, thus "invisible" (for example, run
man man)For other terminals this change shouldn't make a difference.
Notes:
"Coloured" bold colours are unaffected by this change
I tested these changes on macOS with iTerm and on Void Linux with Alacritty
Reference:
https://iterm2.com/3.3/documentation-escape-codes.html
http://pod.tst.eu/http://cvs.schmorp.de/rxvt-unicode/doc/rxvt.7.pod#XTerm_Operating_System_Commands
Screenshots:
"Invisible" bold colours:
Fixed bold colors:
Other working unchanged coloured bold colours:
