Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support required vs nullable #10

Closed
wants to merge 4 commits into from
Closed

Support required vs nullable #10

wants to merge 4 commits into from

Conversation

bhelx
Copy link
Contributor

@bhelx bhelx commented Oct 23, 2024

No description provided.

@bhelx bhelx force-pushed the required-vs-nullable branch from efbb4be to 6ac637c Compare October 23, 2024 18:42
@bhelx bhelx requested a review from zshipko October 23, 2024 18:42
@bhelx
Copy link
Contributor Author

bhelx commented Oct 23, 2024

@zshipko could i get a hand with the tests here? it seems i'm upsetting some macro that i just don't know how to mentally decode.

@zshipko
Copy link
Contributor

zshipko commented Oct 23, 2024

The issue is that we end up with a field like:

        #[serde(rename = "value")]
        #[serde(with = "Base64Standard")]
        pub value: Option<Vec<u8>>,

where Base64Standard encoding doesn't work because it expects Vec<u8> - maybe we could work around this using a newtype with its own serialize/deserialize implementations. I need to look into other options, but we could also just replace the #[serde(with = "Base64Encoder")] with another encoder that works on Option values.

@bhelx bhelx mentioned this pull request Nov 4, 2024
@bhelx
Copy link
Contributor Author

bhelx commented Nov 4, 2024

Closing in favor of #15

@bhelx bhelx closed this Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants