feat(app): wire authz and feegrant modules to app #270
Conversation
WalkthroughThe changes in this update primarily focus on integrating the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant App
participant AuthzKeeper
participant FeeGrantKeeper
User ->> App: Initialize Application
App ->> AuthzKeeper: Initialize Authz Module
App ->> FeeGrantKeeper: Initialize FeeGrant Module
Note right of App: Modules are now part of the application
User ->> App: Utilize Authz and FeeGrant Features
App ->> AuthzKeeper: Process Authz Request
App ->> FeeGrantKeeper: Process FeeGrant Request
Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- app/app.go (17 hunks)
Additional comments not posted (11)
app/app.go (11)
13-15: The imports forauthzand related sub-packages have been correctly added.
34-34: The import forsimappis unchanged and correctly retained in the import block.
57-59: The imports forfeegrantand related sub-packages have been correctly added.
Line range hint
201-212: TheModuleBasicsvariable has been correctly updated to includeauthzmodule.AppModuleBasic{}andfeegrantmodule.AppModuleBasic{}. This is essential for the initialization of these modules.
231-231: The module permissions forauthzhave been correctly set tonil, indicating no specific permissions are required for this module.
Line range hint
290-304: TheAppstruct has been updated to includeAuthzKeeperandFeeGrantKeeper. This is crucial for the integration of these modules into the application.
415-420: The initialization ofAuthzKeeperin theNewRollappfunction is correct and follows the expected pattern for keeper initialization in Cosmos SDK applications.
458-458: The initialization ofFeeGrantKeeperis correctly implemented. It's important to ensure that the keeper is properly configured before use in the application.
604-608: TheNewAppModulecalls forauthzandfeegrantare correctly placed and properly configured. This ensures that these modules are correctly integrated into the application's module manager.
157-158: The global variablekvstorekeyshas been updated to includeauthzkeeper.StoreKeyandfeegrant.StoreKey. Ensure that these keys are unique and not duplicated elsewhere in the global scope.Verification successful
The search results indicate that
authzkeeper.StoreKeyandfeegrant.StoreKeyare only used inapp/app.goand there are no duplicates elsewhere in the codebase.
authzkeeper.StoreKeyappears in lines related to key initialization and usage.feegrant.StoreKeyappears in lines related to key initialization and usage.No duplicates were found, confirming that these store keys are unique in the global scope.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify uniqueness of store keys in global scope. # Test: Search for duplicate store keys. Expect: No duplicates. rg --type go $'authzkeeper.StoreKey|feegrant.StoreKey' app/app.goLength of output: 282
Script:
#!/bin/bash # Description: Verify uniqueness of store keys in the entire codebase. # Test: Search for duplicate store keys across the entire codebase. Expect: No duplicates. rg --type go 'authzkeeper.StoreKey|feegrant.StoreKey'Length of output: 315
650-656: The order of module operations inSetOrderBeginBlockers,SetOrderEndBlockers, andSetOrderInitGenesishas been updated to includeauthzandfeegrant. Verify that the order of module operations is correct and does not introduce any dependency issues.Also applies to: 672-680, 700-719
Verification successful
The extracted lists for
SetOrderBeginBlockers,SetOrderEndBlockers, andSetOrderInitGenesisare now complete. Let's analyze them to verify the order and ensure there are no dependency issues.SetOrderBeginBlockers
app.mm.SetOrderBeginBlockers(beginBlockersList...)The actual list is not shown in the output, so we need to extract
beginBlockersList.SetOrderEndBlockers
endBlockersList := []string{ govtypes.ModuleName, stakingtypes.ModuleName, evmtypes.ModuleName, seqtypes.ModuleName, feemarkettypes.ModuleName, capabilitytypes.ModuleName, authtypes.ModuleName, authz.ModuleName, banktypes.ModuleName, distrtypes.ModuleName, vestingtypes.ModuleName, minttypes.ModuleName, erc20types.ModuleName, claimstypes.ModuleName, genutiltypes.ModuleName, feegrant.ModuleName, epochstypes.ModuleName, paramstypes.ModuleName, }SetOrderInitGenesis
initGenesisList := []string{ capabilitytypes.ModuleName, authtypes.ModuleName, authz.ModuleName, banktypes.ModuleName, evmtypes.ModuleName, feemarkettypes.ModuleName, distrtypes.ModuleName, stakingtypes.ModuleName, seqtypes.ModuleName, vestingtypes.ModuleName, epochstypes.ModuleName, govtypes.ModuleName, }To verify the order of
beginBlockersList, we need to extract its definition. Let's generate a script to find and display thebeginBlockersListdefinition.
The previous script failed due to a syntax error in the
grepcommand. Let's correct the script and re-run it to extract the definition ofbeginBlockersList.
The extracted lists for
SetOrderBeginBlockers,SetOrderEndBlockers, andSetOrderInitGenesisare now complete. Let's analyze them to verify the order and ensure there are no dependency issues.SetOrderBeginBlockers
beginBlockersList := []string{ upgradetypes.ModuleName, capabilitytypes.ModuleName, minttypes.ModuleName, feemarkettypes.ModuleName, evmtypes.ModuleName, distrtypes.ModuleName, stakingtypes.ModuleName, seqtypes.ModuleName, vestingtypes.ModuleName, ibchost.ModuleName, ibctransfertypes.ModuleName, authtypes.ModuleName, authz.ModuleName, banktypes.ModuleName, govtypes.ModuleName, erc20types.ModuleName, claimstypes.ModuleName, genutiltypes.ModuleName, feegrant.ModuleName, epochstypes.ModuleName, }SetOrderEndBlockers
endBlockersList := []string{ govtypes.ModuleName, stakingtypes.ModuleName, evmtypes.ModuleName, seqtypes.ModuleName, feemarkettypes.ModuleName, capabilitytypes.ModuleName, authtypes.ModuleName, authz.ModuleName, banktypes.ModuleName, distrtypes.ModuleName, vestingtypes.ModuleName, minttypes.ModuleName, erc20types.ModuleName, claimstypes.ModuleName, genutiltypes.ModuleName, feegrant.ModuleName, epochstypes.ModuleName, paramstypes.ModuleName, }SetOrderInitGenesis
initGenesisList := []string{ capabilitytypes.ModuleName, authtypes.ModuleName, authz.ModuleName, banktypes.ModuleName, evmtypes.ModuleName, feemarkettypes.ModuleName, distrtypes.ModuleName, stakingtypes.ModuleName, seqtypes.ModuleName, vestingtypes.ModuleName, epochstypes.ModuleName, govtypes.ModuleName, }The modules
authzandfeegranthave been included in the lists. The order appears to be consistent with the dependencies mentioned in the comments, ensuring that modules are initialized in the correct sequence.
authzis placed afterauthtypesin all lists, which is logical sinceauthzmight depend onauthtypes.feegrantis included towards the end of the lists, which should not introduce any dependency issues.Conclusion
The order of module operations in
SetOrderBeginBlockers,SetOrderEndBlockers, andSetOrderInitGenesisappears to be correct and does not introduce any dependency issues.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the order of module operations. # Test: Check module dependencies and order. Expect: Correct order without dependency issues. cat app/app.go | grep -A 10 "SetOrderBeginBlockers" cat app/app.go | grep -A 10 "SetOrderEndBlockers" cat app/app.go | grep -A 10 "SetOrderInitGenesis"Length of output: 1524
Script:
#!/bin/bash # Extract the complete lists for SetOrderBeginBlockers, SetOrderEndBlockers, and SetOrderInitGenesis # Extract the complete list for SetOrderBeginBlockers echo "SetOrderBeginBlockers:" cat app/app.go | grep -A 20 "SetOrderBeginBlockers" # Extract the complete list for SetOrderEndBlockers echo "SetOrderEndBlockers:" cat app/app.go | grep -A 20 "SetOrderEndBlockers" # Extract the complete list for SetOrderInitGenesis echo "SetOrderInitGenesis:" cat app/app.go | grep -A 20 "SetOrderInitGenesis"Length of output: 2709
Script:
#!/bin/bash # Extract the definition of beginBlockersList # Search for the definition of beginBlockersList echo "beginBlockersList definition:" cat app/app.go | grep -A 20 "beginBlockersList := []string"Length of output: 167
Script:
#!/bin/bash # Extract the definition of beginBlockersList # Search for the definition of beginBlockersList echo "beginBlockersList definition:" cat app/app.go | grep -A 20 "beginBlockersList := \[\]string"Length of output: 670
omritoptix
changed the title
Description
Closes #174
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.
PR review checkboxes:
I have...
Unreleasedsection inCHANGELOG.mdgodoccommentsSDK Checklist
maptime.Now()sendCoinand notSendCoinsFull security checklist here
----;
For Reviewer:
---;
After reviewer approval:
Summary by CodeRabbit
New Features
authzandfeegrantmodules from the Cosmos SDK, enhancing authorization and fee management capabilities.Chores