generated from dymensionxyz/rollapp
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(genesis bridge): genesis transfers #279
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks @srene I've fixed the readme now |
mtsitrin
reviewed
Jun 19, 2024
mtsitrin
previously approved these changes
Jun 19, 2024
mtsitrin
reviewed
Jun 20, 2024
danwt
commented
Jun 20, 2024
zale144
reviewed
Jun 20, 2024
zale144
reviewed
Jun 20, 2024
zale144
reviewed
Jun 21, 2024
mtsitrin
approved these changes
Jun 25, 2024
danwt
commented
Jul 2, 2024
Comment on lines
+21
to
+23
# ---------------------------- add genesis accounts for the hub ---------------------------- # | ||
genesis_accounts=$(cat "$ROLLAPP_SETTLEMENT_INIT_DIR_PATH"/genesis_accounts.json) | ||
jq --argjson genesis_accounts "$genesis_accounts" '.app_state.hubgenesis.state.genesis_accounts = $genesis_accounts' "$GENESIS_FILE" >"$tmp" && mv "$tmp" "$GENESIS_FILE" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See
https://github.com/dymensionxyz/research/issues/278 for the master issue.
There are a few outstanding items, that this PR does not try to solve.
This PR:
-y
to register rollapp / register sequencer cmdsNOTE: I will update the go.mod to the correct dependencies after the other prs are merged
Closes #278
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.
PR review checkboxes:
I have...
Unreleased
section inCHANGELOG.md
godoc
commentsSDK Checklist
map
time.Now()
sendCoin
and notSendCoins
Full security checklist here
----;
For Reviewer:
---;
After reviewer approval:
Summary by CodeRabbit
New Features
Improvements
Permissions
TransferKeeper
initialization for better control.