-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(denommetadata): wire the denommetadata ibc middleware #283
Conversation
@@ -22,6 +22,6 @@ dymd tx rollapp create-rollapp "$ROLLAPP_CHAIN_ID" "$MAX_SEQUENCERS" '{"Addresse | |||
--keyring-backend test \ | |||
--broadcast-mode block \ | |||
--fees 1dym \ | |||
-y | |||
--transfers-enabled true -y |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this change is not needed
@zale144 why did we remove the authz and feegrant module? |
bad merge. I'll fix it |
) | ||
|
||
denomMetadataMiddleware := denommetadata.NewICS4Wrapper( | ||
app.ClaimsKeeper, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zale144 why we need the claims keeper?
it's unused and planned to be removed asap
Description
ssee https://github.com/dymensionxyz/dymension-rdk/pull/455/files
Closes #282
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.
PR review checkboxes:
I have...
Unreleased
section inCHANGELOG.md
godoc
commentsSDK Checklist
map
time.Now()
sendCoin
and notSendCoins
Full security checklist here
----;
For Reviewer:
---;
After reviewer approval: