Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add report_url param to CloudForCustomers.extract_records() #1071

Merged
merged 2 commits into from
Oct 4, 2024
Merged

✨ Add report_url param to CloudForCustomers.extract_records() #1071

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
883e9b8
added report_url argument
fdelgadodyvenia Sep 30, 2024
7826b54
✨ Added `get_secret_value`
Rafalz13 Oct 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/viadot/sources/cloud_for_customers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,7 @@ def get_response(
return handle_api_response(
url=url,
params=filter_params,
auth=(username, password),
auth=(username, password.get_secret_value()),
timeout=timeout,
)

Expand Down Expand Up @@ -318,7 +318,7 @@ def to_df(
tests: dict[str, Any] = kwargs.get("tests", {})

url = url or self.url
records = self.extract_records(url=url)
records = self.extract_records(url=url, report_url=self.report_url)
trymzet marked this conversation as resolved.
Show resolved Hide resolved
df = pd.DataFrame(data=records, **kwargs)

if dtype:
Expand Down