Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix password parsing in CloudForCustomer source #1088

Merged
merged 2 commits into from
Oct 10, 2024
Merged

🐛 Fix password parsing in CloudForCustomer source #1088

merged 2 commits into from
Oct 10, 2024

Conversation

Rafalz13
Copy link
Contributor

@Rafalz13 Rafalz13 commented Oct 9, 2024

Summary

It was a bug. It should be fixed to properly authenticate.

Importance

Checklist

This PR:

  • follows the guidelines laid out in CONTRIBUTING.md
  • links relevant issue(s)
  • adds/updates tests (if appropriate)
  • adds/updates docstrings (if appropriate)
  • adds an entry in CHANGELOG.md

@Rafalz13 Rafalz13 added bug Something isn't working 2.0 viadot 2.0 labels Oct 9, 2024
@Rafalz13 Rafalz13 requested a review from trymzet October 9, 2024 13:35
@trymzet trymzet merged commit 27e158c into 2.0 Oct 10, 2024
3 checks passed
@trymzet trymzet deleted the c4c_mapping_col_names branch October 10, 2024 09:48
@trymzet trymzet changed the title ✨ Insert getting password for C4C source 🐛 Fix password credential retrieval in CloudForCustomer source Oct 10, 2024
@trymzet trymzet changed the title 🐛 Fix password credential retrieval in CloudForCustomer source 🐛 Fix password credential parsing in CloudForCustomer source Oct 10, 2024
@trymzet trymzet changed the title 🐛 Fix password credential parsing in CloudForCustomer source 🐛 Fix password parsing in CloudForCustomer source Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trymzet trymzet trymzet approved these changes

Assignees
No one assigned
Labels
2.0 viadot 2.0 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rafalz13 @trymzet @fdelgadodyvenia